MudMenu: Hide Button when Label, Icon and Content are unset

[meenzen]

Description

see #10122 (comment)

Before:

After:

New docs section:

How Has This Been Tested?

unit, visually

Type of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (fix or improvement to the website or code docs)

Checklist

• The PR is submitted to the correct branch (dev).
• My code follows the code style of this project.
• I've added relevant tests.

[meenzen]

@ScarletKuro do you think this is the right approach? Also I'm not sure about the parameter name Hidden, any better ideas?

If you think this is OK I can add tests and docs tomorrow.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (43fbb95) to head (ca14c64).
Report is 8 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10349      +/-   ##
==========================================
- Coverage   91.48%   91.43%   -0.06%     
==========================================
  Files         415      417       +2     
  Lines       13053    13222     +169     
  Branches     2473     2538      +65     
==========================================
+ Hits        11942    12089     +147     
- Misses        548      554       +6     
- Partials      563      579      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[versile2]

Had to get caught up, question- Shouldn't that button always be hidden or visibility collapse or something when not in a popover? I think could probably solve it all with just a css class when laid out in that manner under a popover to not show it and disable it but the popover version would work fine

[ScarletKuro]

@versile2 @henon @danielchalmers
What do you guys think? I think this solution is good for edge cases. Ideally, it would be great if the DataGrid natively supported context menus on rows and allowed customization. Then MudMenu near the DataGrid with PositionAtCursor="true" wouldn't be necessary. However, since there isn't such support, I think the proposed solution is the only workaround.

[danielchalmers]

Might be a stupid question but why can't we add the mud-menu-hidden class if the activator content is null? Why do we need a second property?

[henon]

I guess @danielchalmers has a point. Should we decide to keep the parameter though I'd like it to be named ShowButton instead.

[meenzen]

Might be a stupid question but why can't we add the mud-menu-hidden class if the activator content is null? Why do we need a second property?

When the activator content is null a default button is shown. That's the main use of MudMenu.

[danielchalmers]

Might be a stupid question but why can't we add the mud-menu-hidden class if the activator content is null? Why do we need a second property?

When the activator content is null a default button is shown. That's the main use of MudMenu.

Right, no activator content or label = hidden?

<MudMenu>
    <MudMenuItem>Enlist</MudMenuItem>
    <MudMenuItem>Barracks</MudMenuItem>
    <MudMenuItem>Armory</MudMenuItem>
</MudMenu>

Do people use the empty button that's shown in your Before example?

[meenzen]

Right, no activator content or label = hidden?

I like this idea.

Do people use the empty button that's shown in your Before example?

I hope not. I think this behavior qualifies as unintended / buggy.

[henon]

Right, no activator content or label = hidden?

I like this idea.

We can do this but we should explicitly document it with an example in the docs.

[meenzen]

I had to remove these test cases because the button isn't rendered anymore when the label is null.

[danielchalmers]

Cool!

[henon]

Thanks @meenzen