Merged
Conversation
ibrand
reviewed
Feb 5, 2024
ibrand
left a comment
There was a problem hiding this comment.
We did a talking PR for this, and agreed that Kathy could add a test to the PR. I'll approve once the test is in!
codygordon
approved these changes
Feb 12, 2024
|
Author
|
@ibrand Added Jest tests to verify SQL queries when |
codygordon
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
There are time and bandwidth limitations on API calls and their responses when Spoke is deployed on AWS Lambda. This can cause an indefinite 504 error on the TexterTodo page If a texter is assigned a lot of contacts (~>=50,000).
This PR adds an ASSIGNMENT_LOAD_LIMIT variable to limit the number of contacts fetched by the getContacts(...) API call at one time.
Checklist: