Conversation
Generates a special link used to reassign replies. Known bugs: replies can be reassigned indefinitely because the `updated_at` field in `campaign_contact` does not actually update on reassignment.
|
@ibrand Can you confirm if we can remove the SonarCloud check? |
crayolakat
suggested changes
May 3, 2024
There was a problem hiding this comment.
Looks good! I left some comments, and also suggest changing the organizationUuid variable name in the dynamicReassign function to campaignJoinToken or joinToken to reflect what it actually is!
Also, the SonarCloud test is failing but I think MoveOn is no longer using SonarCloud so the check can be removed. I tagged Ilona to verify.
…using the joinToken value Also remove an unnecessary import and fix a comment
|
crayolakat
approved these changes
May 3, 2024
|
Yep, we're planning to remove Sonarcloud. Are any of these issues worthy of fixing while we still have it? |
This was referenced May 15, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ProgressiveCoders#2357
Description
Add a new option under "Dynamic Assignment" under campaign setup which creates a special link. That link is used to reassign "needs reply" conversations dynamically - whenever a user goes to that link they will receive up to (batch size) conversations that need a reply and have not been reassigned in the past hour.
Checklist: