Auto by pass#20
Merged
Merged
Conversation
Previous intake command would not start the intake rollers.
Dylan-Powers
reviewed
Apr 9, 2024
| () -> driverB.getAsBoolean(), | ||
| () -> false, | ||
| () -> s_Eyes.getTargetRotation(), | ||
| () -> false,//driverB.getAsBoolean(), |
Dylan-Powers
reviewed
Apr 9, 2024
| rotationSpeed, | ||
| true | ||
| ).alongWith(new AimShoot(s_Eyes, s_ShooterPivot, s_Shooter, true)), | ||
| false //TODO: Determine if we want auto rotation aiming |
Member
There was a problem hiding this comment.
remove TODO comment and change to true. Drive team wants auto aim while using the elevator shot
Dylan-Powers
reviewed
Apr 9, 2024
Dylan-Powers
reviewed
Apr 9, 2024
| import frc.robot.subsystems.Shooter; | ||
| import frc.robot.subsystems.ShooterPivot; | ||
|
|
||
| import java.sql.Driver; |
Member
There was a problem hiding this comment.
We are definitely not using SQL so we can definitely get rid of this import
Dylan-Powers
reviewed
Apr 9, 2024
| shooterSpeedInterpolation = new InterpolatingDoubleTreeMap(); | ||
|
|
||
| // create points in angle linear interpolation line | ||
| // TODO tune these values |
Member
There was a problem hiding this comment.
Remove TODO, these are tuned
Dylan-Powers
reviewed
Apr 9, 2024
| shooterSpeedInterpolation = new InterpolatingDoubleTreeMap(); | ||
|
|
||
| // create points in angle linear interpolation line | ||
| // TODO tune these values |
Member
There was a problem hiding this comment.
remove this TODO, these are definitely tuned
Dylan-Powers
reviewed
Apr 9, 2024
| shooterAngleInterpolationAuto.put(d3DistanceAuto, d3AngleAuto); | ||
| shooterAngleInterpolationAuto.put(xSpotDistanceAuto, xSpotAngleAuto); | ||
| // create points in angle linear interpolation line | ||
| // TODO tune these values |
Member
There was a problem hiding this comment.
remove TODO, these are tuned
Dylan-Powers
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.