feat(hooks): expose session_dir and inject SessionStart hook output into main agent context#847
Open
AzazelSensei wants to merge 3 commits into
Open
Conversation
…n payload - Append non-empty SessionStart hook stdout/message to the main agent context as a hook_result message, mirroring UserPromptSubmit behavior. - Add session_dir to the base hook payload so external integrations can locate session artifacts (e.g. wire.jsonl).
🦋 Changeset detectedLatest commit: 59edaa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74ba296e87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Skip timed-out / non-zero-exit SessionStart hook results before injecting their output into the main agent context (mirrors the UserPromptSubmit path), so partial/error output isn't treated as recall data. - Mark SessionStart as non-blocking in the hooks reference; it injects context but cannot block startup. - Mirror the session_dir payload field and the updated SessionStart description into the zh docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables external persistent-memory hooks for Kimi Code CLI by:
session_dirto every hook payload so hooks can locate the session wire log.SessionStarthook results and appending non-empty stdout/message text to the main agent context, matching the hook contract used by Claude/Codex.Motivation: third-party memory layers need to inject a recall block at session start and know where the transcript lives.
Tests:
npm_config_engine_strict=false pnpm --filter @moonshot-ai/agent-core test→ 2605 passed.