Skip to content

[2017] 修复 macOS CD: goldfish 18.x path-join 返回 path record#3856

Merged
Yuki-Nagori merged 6 commits into
mainfrom
yuki/2017/macos
Jun 30, 2026
Merged

[2017] 修复 macOS CD: goldfish 18.x path-join 返回 path record#3856
Yuki-Nagori merged 6 commits into
mainfrom
yuki/2017/macos

Conversation

@Yuki-Nagori

Copy link
Copy Markdown
Contributor

Summary

  • goldfish 18.x([2016] 升级 Goldfish 到 18.11.15(base64/string->utf8 改用 C++ 实现) #3851 升级到 18.11.15)重构了 (liii path)path-join 改为返回 path record 而非字符串,导致 packages/macos/package.scm 在脚本加载阶段(realpath 计算 PACKAGE_HOME)就因 string-append 收到 path record 而崩掉,macOS CD 在 Run chmod +x TeXmacs/plugins/goldfish/bin/goldfish 步骤直接失败
  • package.scm 全部 17 处 path-join 调用点用 path->string 包裹,恢复字符串语义
  • path->string(liii path) 的标准导出,接受 path record 或 string,包一层无副作用,对 17.x 行为完全兼容

Test plan

  • 手动触发 cd_on_macos_arm64.yml workflow_dispatch
  • 确认 Run chmod +x TeXmacs/plugins/goldfish/bin/goldfish 步骤不再报 string-append second argument ... is a let but should be string
  • 确认脚本进入 xmake config / xmake build 阶段
  • 确认 DMG 打包与签名流程跑通

🤖 Generated with Claude Code

@da-liii da-liii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yuki-Nagori Yuki-Nagori merged commit 78e5632 into main Jun 30, 2026
@Yuki-Nagori Yuki-Nagori deleted the yuki/2017/macos branch June 30, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants