[2017] 修复 macOS CD: goldfish 18.x path-join 返回 path record#3856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(liii path),path-join改为返回 path record 而非字符串,导致packages/macos/package.scm在脚本加载阶段(realpath计算PACKAGE_HOME)就因string-append收到 path record 而崩掉,macOS CD 在Run chmod +x TeXmacs/plugins/goldfish/bin/goldfish步骤直接失败package.scm全部 17 处path-join调用点用path->string包裹,恢复字符串语义path->string是(liii path)的标准导出,接受 path record 或 string,包一层无副作用,对 17.x 行为完全兼容Test plan
cd_on_macos_arm64.ymlworkflow_dispatchRun chmod +x TeXmacs/plugins/goldfish/bin/goldfish步骤不再报string-append second argument ... is a let but should be stringxmake config/xmake build阶段🤖 Generated with Claude Code