Skip to content

[Compat] Windows: Visual Studio Auto detection #66

Description

@Qubitium

The problem is cmake on windows requires visual studio and the cmake requires us to pass the full visual studio version as cmake param. The current code has a default VS version and user can override this to fit their system but most people don't even know what version they have let alone how to export env vars in windows cli.

Proposal: Auto detect VS studio version in python setup.py and pass the correct version to CMAKE_GENERATOR

ModelCloud/GPTQModel#2425
https://github.com/ModelCloud/PyPcre/pull/64/changes

@sbhmajum369 We are tracking the long term fix for your window visualstudio install issue here. In the mean time, export CMAKE_GENERATOR var and set to the same visual studio version as installed in your windows machine.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions