Feature/torch_ranker #251
Merged
Feature/torch_ranker #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsundalov
commented
Feb 3, 2025
…r_pairs_csr; implicit ranker non-interface args to constructor
blondered
reviewed
Feb 4, 2025
blondered
reviewed
Feb 4, 2025
blondered
reviewed
Feb 4, 2025
blondered
reviewed
Feb 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 64 +19
Lines 2242 4138 +1896
===========================================
+ Hits 2242 4138 +1896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feldlime
requested changes
Feb 6, 2025
Collaborator
feldlime
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR! I looks great, especially because implicit often don't see the GPU
I added just a few small comments to finalize it
blondered
reviewed
Feb 6, 2025
feldlime
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New torch ranker to allow ranking with gpu.
Type of change
New feature (non-breaking change which adds functionality)