Drop Python 3.8 Support #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 59 +14
Lines 2242 3872 +1630
===========================================
+ Hits 2242 3872 +1630 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f8ebb8c to
3b26148
Compare
Collaborator
|
@chezou Thanks for the PR! Before merging, we have to ensure that nobody in the company uses Python 3.8. It may take a few days |
Contributor
Author
|
@feldlime Got it. Due to the PyTorch issue, the current pyproject.toml fails to install with Python 3.8 pytorch/pytorch#139005 |
feldlime
requested changes
Dec 9, 2024
This change makes Python 3.12 installation easier, especially by preventing pandas build since locked pandas version does not have wheels for Python 3.12.
This reverts commit 3b26148.
Co-authored-by: Emiliy Feldman <[email protected]>
Contributor
Author
|
@feldlime Applied review comments and rebased toward main. |
feldlime
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Python 3.8 is EoL, this change makes Python 3.12 installation easier, especially by preventing pandas build since locked pandas version does not have wheels for Python 3.12.
PyTorch will likely support Python 3.13 early next year, so I skipped to support Python 3.13.
pytorch/pytorch#130249
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.