Skip to content

Conversation

@feldlime
Copy link
Collaborator

@feldlime feldlime commented Jul 31, 2024

Description

  • Added configs to models

Сloses #108
Closes #157

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (df1fbac).
Report is 93 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #170     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        57     +12     
  Lines         2242      3744   +1502     
===========================================
+ Hits          2242      3744   +1502     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

feldlime and others added 6 commits August 1, 2024 18:14
- Added configs for `implicit` models
- Added model configs for `EASE`, `Random` and `PureSVD` models
- Moved `RandomState` serialization to models/base.py
Added model configs for `Popular` and `PopularInCategory` models.
- Added config for LightFM model
@feldlime feldlime marked this pull request as ready for review October 24, 2024 05:53
@feldlime feldlime requested a review from blondered October 24, 2024 05:53
@blondered
Copy link
Collaborator

Please add that this PR closes two issues #108 and #157

Co-authored-by: Daria <[email protected]>
@feldlime feldlime merged commit 0d1df86 into main Nov 9, 2024
@feldlime feldlime deleted the feature/model_configs branch November 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrappers initialisation from full list of hyper-params

4 participants