Switch from ktlint -> ktfmt

[eyalgu]

It seems like ktlint keeps triping me up because it doesn't support running as part of the workflow (I make a small change, forget to fix some spacing then get a failure). I'd like to try out https://github.com/facebookincubator/ktfmt.
I know the maintainers and would love to give it a try

[ychescale9]

Hmm looks like there's no published artifact yet and it requires maven 🙃?

[eyalgu]

Yeah, I would check in a binary

…

On Wed, Feb 19, 2020, 6:05 PM Yang ***@***.***> wrote: Hmm looks like there's no published artifact yet and it requires maven 🙃? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#116>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMUYKK3SGPCIXJNGX2JJMTRDXQPLANCNFSM4KX6B6UA> .

[tasomaniac]

ktfmt is not a full replacement, right? ktlint is a formatter but also a linter.

[cgrushko]

@ychescale9 @eyalgu we started publishing artifacts to Maven Central: https://search.maven.org/artifact/com.facebook/ktfmt/0.12/jar

@tasomaniac correct; ktfmt is a code formatter. It's analogous to google-java-format in the Java world.

[cgrushko]

diffplug/spotless#569 is bringing ktfmt to Spotless. I see Store already uses Spotless, so it should be easy to try out ktfmt.

[biratdatta]

Yeah it is a good issue, require a discussion for it.

[itsandreramon]

i can provide a PR for that if wanted

[matt-ramotar]

@itsandreramon We haven’t experienced major friction with ktlint lately, so this hasn’t been a priority. However, I'm open to a PR that explores switching to ktfmt. The PR would need to:

• Minimize blame breakage (not sure how big of a concern this is in practice)
• Integrate with Spotless
• Integrate with Detekt to maintain existing lint rules
• Update our build/CI workflow
• Update the CONTRIBUTING guide accordingly

Happy to discuss if you'd like to take it on

[itsandreramon]

@matt-ramotar do you want to have the googleStyle() of ktfmt or should we keep current indentation? Google's style is 2 space indentation.