-
Notifications
You must be signed in to change notification settings - Fork 44
chore: Revise design of "bottom actions" #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9c9f6c0
chore: Mockup of updated layout of bottom actions
cyanChill f660f65
chore: Add some animations
cyanChill 6628baf
chore: Fix animations
cyanChill 8b1c266
chore: Move where we export the hook
cyanChill 2958030
chore: Fix offsets on the home screen based on the 3 cases
cyanChill 11b18cf
Note: Swipe gestures break only in dev mode
cyanChill d54e81d
chore: Update promo image
cyanChill f498d79
fix: No offset applied when navbar & miniplayer are hidden
cyanChill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { useMemo } from "react"; | ||
| import { View } from "react-native"; | ||
| import Animated, { LinearTransition } from "react-native-reanimated"; | ||
|
|
||
| import { usePreferenceStore } from "~/stores/Preference/store"; | ||
| import { useRenderBottomActions } from "./useBottomActions"; | ||
|
|
||
| import { MiniPlayer } from "./MiniPlayer"; | ||
| import { Navbar, SearchButton, SettingsButton } from "./NavActions"; | ||
|
|
||
| //#region Bottom Actions | ||
| /** Actions stickied to the bottom of the screens. */ | ||
| export function BottomActions() { | ||
| const showNavbar = usePreferenceStore((s) => s.showNavbar); | ||
|
|
||
| const BottomActionsLayout = useMemo( | ||
| () => (showNavbar ? WithNavBar : WithOutNavBar), | ||
| [showNavbar], | ||
| ); | ||
|
|
||
| // Extra `View` is to fix positioning when button navigation is selected. | ||
| return ( | ||
| <View> | ||
| <Animated.View | ||
| layout={LinearTransition} | ||
| pointerEvents="box-none" | ||
| className="absolute bottom-0 left-0 w-full items-end gap-2 p-4 pt-0" | ||
| > | ||
| <BottomActionsLayout /> | ||
| </Animated.View> | ||
| </View> | ||
| ); | ||
| } | ||
| //#endregion | ||
|
|
||
| /** Bottom action layout when the user wants to show the navbar. */ | ||
| function WithNavBar() { | ||
| const rendered = useRenderBottomActions(); | ||
| return ( | ||
| <> | ||
| {rendered.miniPlayer ? <MiniPlayer /> : null} | ||
| {rendered.navBar ? ( | ||
| <Animated.View | ||
| layout={LinearTransition} | ||
| className="-z-1 w-full flex-row gap-2" | ||
| > | ||
| <SearchButton /> | ||
| <Navbar /> | ||
| <SettingsButton /> | ||
| </Animated.View> | ||
| ) : null} | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| /** Bottom action layout when the user doesn't want to show the navbar. */ | ||
| function WithOutNavBar() { | ||
| const rendered = useRenderBottomActions(); | ||
| return ( | ||
| <Animated.View | ||
| layout={LinearTransition} | ||
| className="w-full flex-row justify-between gap-2" | ||
| > | ||
| {rendered.navBar ? <SearchButton /> : null} | ||
| {rendered.miniPlayer ? ( | ||
| <Animated.View layout={LinearTransition} className="w-full shrink grow"> | ||
| <MiniPlayer /> | ||
| </Animated.View> | ||
| ) : null} | ||
| {rendered.navBar ? <SettingsButton /> : null} | ||
| </Animated.View> | ||
|
cyanChill marked this conversation as resolved.
|
||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.