Skip to content

Adopt pyplatec 1.4.0#137

Merged
psi29a merged 1 commit intomasterfrom
plate_tectonics_140
Oct 17, 2015
Merged

Adopt pyplatec 1.4.0#137
psi29a merged 1 commit intomasterfrom
plate_tectonics_140

Conversation

@ftomassetti
Copy link
Member

Let's take advantage of the speed improvements we got in the new version of plate-tectonics/pyplatec

@ftomassetti ftomassetti mentioned this pull request Oct 16, 2015
6 tasks
@tcld
Copy link
Contributor

tcld commented Oct 16, 2015

This is really, really great! When I last checked, about 25% of the overall time needed to generate a world went into platec. That could go down to a negligible amount.
I am not sure how my perf_opt-branch (#132) does with large worlds, but for smaller ones it already decreased generation times by about 25%. So overall a speed-up of up to a factor of 2 would be feasible for the "next version".

@psi29a
Copy link
Member

psi29a commented Oct 17, 2015

Looking good, merging!

@ftomassetti have you been in contact with our Finnish counterpart? We going to be up-streaming our patches?

psi29a added a commit that referenced this pull request Oct 17, 2015
@psi29a psi29a merged commit 86fb919 into master Oct 17, 2015
@ftomassetti
Copy link
Member Author

Nope, I have not being in contact since he said he was leaving for holidays. I think our fork diverged quite a bit, I hope they are fine accepting our patches. Perhaps it is time to write again to them to present the significantly speedup we got (admittedly, it is possible that I slow down our code while refactoring and this speedup just makes as fast as platec was already originally :D, we should measure that)

@psi29a
Copy link
Member

psi29a commented Oct 17, 2015

@ftomassetti I forwarded you the email he sent (with you in CC) in Sept. So he is back and has a plan. I also sent a reply. You sure you didn't get that?

@ftomassetti ftomassetti deleted the plate_tectonics_140 branch October 31, 2015 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants