Skip to content

[JitDiff X64] [tannergooding] Update Matrix4x4 paths to use the new xplat in ... #2071

Description

@MihuBot

Job completed in 21 minutes 40 seconds (remote runner delay: 1 minute 8 seconds).
dotnet/runtime#130192

Main commit: dotnet/runtime@58dfec7
PR commit: tannergooding/runtime@085db4a

Diffs

Diffs
Found 89 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 158040784
Total bytes of diff: 158044704
Total bytes of delta: 3920 (0.00 % of base)
Total relative delta: 72.25
    diff is a regression.
    relative diff is a regression.


Total byte diff includes -1796 bytes from reconciling methods
	Base had    3 unique methods,     1937 unique bytes
	Diff had    1 unique methods,      141 unique bytes

Top file regressions (bytes):
        4739 : SixLabors.ImageSharp.dasm (0.21 % of base)

Top file improvements (bytes):
        -819 : System.Private.CoreLib.dasm (-0.01 % of base)

2 total files with Code Size differences (1 improved, 1 regressed), 352 unchanged.

Top method regressions (bytes):
         690 (5,307.69 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:Invert(byref,byref):bool (FullOpts)
         214 (9.15 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.TransformExtensions:Transform(SixLabors.ImageSharp.Processing.IImageProcessingContext,SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler):SixLabors.ImageSharp.Processing.IImageProcessingContext (FullOpts)
         211 (9.09 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.TransformExtensions:Transform(SixLabors.ImageSharp.Processing.IImageProcessingContext,SixLabors.ImageSharp.Rectangle,SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler):SixLabors.ImageSharp.Processing.IImageProcessingContext (FullOpts)
         207 (57.02 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:CheckDegenerate(System.Numerics.Matrix4x4) (FullOpts)
         177 (31.55 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendMatrix(System.Numerics.Matrix4x4):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (28.50 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendTranslation(SixLabors.ImageSharp.PointF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (29.26 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendTranslation(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (24.28 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependMatrix(System.Numerics.Matrix4x4):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (22.18 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependTranslation(SixLabors.ImageSharp.PointF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (22.63 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependTranslation(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (30.37 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.Processors.Transforms.ProjectiveTransformProcessor:.ctor(System.Numerics.Matrix4x4,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler,SixLabors.ImageSharp.Size):this (FullOpts)
         174 (22.86 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendRotationDegrees(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (23.11 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendRotationRadians(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (27.36 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendScale(float):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (25.97 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendScale(SixLabors.ImageSharp.SizeF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (26.61 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendScale(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (18.55 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependRotationDegrees(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (18.71 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependRotationRadians(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (21.22 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependScale(float):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (20.37 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependScale(SixLabors.ImageSharp.SizeF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (20.76 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependScale(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (17.77 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependSkewDegrees(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (18.26 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependSkewRadians(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (27.40 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.TransformExtensions:Transform(SixLabors.ImageSharp.Processing.IImageProcessingContext,SixLabors.ImageSharp.Rectangle,System.Numerics.Matrix4x4,SixLabors.ImageSharp.Size,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler):SixLabors.ImageSharp.Processing.IImageProcessingContext (FullOpts)
         172 (21.58 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendSkewDegrees(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         172 (22.31 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendSkewRadians(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         161 (1,238.46 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4:GetDeterminant():float:this (FullOpts)
         157 (64.08 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.Processors.Transforms.TransformUtilities:IsDegenerate(System.Numerics.Matrix4x4):bool (FullOpts)
         141 (Infinity of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:Shuffle2(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[float],byte,byte,byte,byte):System.Runtime.Intrinsics.Vector128`1[float] (FullOpts) (0 base, 1 diff methods)
         126 (8.97 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:Decompose(byref,byref,byref,byref):bool (FullOpts)
         108 (9.10 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:BuildMatrix(SixLabors.ImageSharp.Rectangle):System.Numerics.Matrix4x4:this (FullOpts)

Top method improvements (bytes):
       -1187 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:<Invert>g__SoftwareFallback|53_1(byref,byref):bool (FullOpts) (1 base, 0 diff methods)
        -707 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:<Invert>g__SseImpl|53_0(byref,byref):bool (FullOpts) (1 base, 0 diff methods)
         -43 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:ThrowPlatformNotSupportedException() (FullOpts) (1 base, 0 diff methods)

Top method regressions (percentages):
         141 (Infinity of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:Shuffle2(System.Runtime.Intrinsics.Vector128`1[float],System.Runtime.Intrinsics.Vector128`1[float],byte,byte,byte,byte):System.Runtime.Intrinsics.Vector128`1[float] (FullOpts) (0 base, 1 diff methods)
         690 (5,307.69 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:Invert(byref,byref):bool (FullOpts)
         161 (1,238.46 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4:GetDeterminant():float:this (FullOpts)
         157 (64.08 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.Processors.Transforms.TransformUtilities:IsDegenerate(System.Numerics.Matrix4x4):bool (FullOpts)
         207 (57.02 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:CheckDegenerate(System.Numerics.Matrix4x4) (FullOpts)
         177 (31.55 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendMatrix(System.Numerics.Matrix4x4):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (30.37 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.Processors.Transforms.ProjectiveTransformProcessor:.ctor(System.Numerics.Matrix4x4,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler,SixLabors.ImageSharp.Size):this (FullOpts)
         177 (29.26 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendTranslation(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (28.50 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendTranslation(SixLabors.ImageSharp.PointF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (27.40 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.TransformExtensions:Transform(SixLabors.ImageSharp.Processing.IImageProcessingContext,SixLabors.ImageSharp.Rectangle,System.Numerics.Matrix4x4,SixLabors.ImageSharp.Size,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler):SixLabors.ImageSharp.Processing.IImageProcessingContext (FullOpts)
         174 (27.36 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendScale(float):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (26.61 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendScale(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (25.97 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendScale(SixLabors.ImageSharp.SizeF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (24.28 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependMatrix(System.Numerics.Matrix4x4):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (23.11 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendRotationRadians(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (22.86 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendRotationDegrees(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (22.63 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependTranslation(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         172 (22.31 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendSkewRadians(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         177 (22.18 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependTranslation(SixLabors.ImageSharp.PointF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         172 (21.58 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:AppendSkewDegrees(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (21.22 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependScale(float):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (20.76 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependScale(System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (20.37 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependScale(SixLabors.ImageSharp.SizeF):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (18.71 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependRotationRadians(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (18.55 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependRotationDegrees(float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (18.26 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependSkewRadians(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         174 (17.77 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:PrependSkewDegrees(float,float,System.Numerics.Vector2):SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:this (FullOpts)
         214 (9.15 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.TransformExtensions:Transform(SixLabors.ImageSharp.Processing.IImageProcessingContext,SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler):SixLabors.ImageSharp.Processing.IImageProcessingContext (FullOpts)
         108 (9.10 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder:BuildMatrix(SixLabors.ImageSharp.Rectangle):System.Numerics.Matrix4x4:this (FullOpts)
         211 (9.09 % of base) : SixLabors.ImageSharp.dasm - SixLabors.ImageSharp.Processing.TransformExtensions:Transform(SixLabors.ImageSharp.Processing.IImageProcessingContext,SixLabors.ImageSharp.Rectangle,SixLabors.ImageSharp.Processing.ProjectiveTransformBuilder,SixLabors.ImageSharp.Processing.Processors.Transforms.IResampler):SixLabors.ImageSharp.Processing.IImageProcessingContext (FullOpts)
         126 (8.97 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:Decompose(byref,byref,byref,byref):bool (FullOpts)

Top method improvements (percentages):
       -1187 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:<Invert>g__SoftwareFallback|53_1(byref,byref):bool (FullOpts) (1 base, 0 diff methods)
        -707 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:<Invert>g__SseImpl|53_0(byref,byref):bool (FullOpts) (1 base, 0 diff methods)
         -43 (-100.00 % of base) : System.Private.CoreLib.dasm - System.Numerics.Matrix4x4+Impl:ThrowPlatformNotSupportedException() (FullOpts) (1 base, 0 diff methods)

34 total methods with Code Size differences (3 improved, 31 regressed), 815792 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions