Skip to content

Added videos to "Customize DevTools"#2161

Merged
captainbrosset merged 5 commits intoMicrosoftDocs:mainfrom
mikehoffms:user/mikehoffms/custui-vid
Sep 13, 2022
Merged

Added videos to "Customize DevTools"#2161
captainbrosset merged 5 commits intoMicrosoftDocs:mainfrom
mikehoffms:user/mikehoffms/custui-vid

Conversation

@mikehoffms
Copy link
Copy Markdown
Collaborator

@mikehoffms mikehoffms commented Sep 8, 2022

@opbld33
Copy link
Copy Markdown

opbld33 commented Sep 8, 2022

Docs Build status updates of commit 545b825:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/customize/index.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link
Copy Markdown

opbld33 commented Sep 8, 2022

Docs Build status updates of commit 3c88305:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/customize/index.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@captainbrosset
Copy link
Copy Markdown
Contributor

Two quick ideas as I look at this PR:

  • Could we make the video links look more like videos? Since they're just links now, it's easy to miss them I guess. We could use the same thumbnail images we use on the https://aka.ms/edge-dev-videos page.
  • I'm not too sure about this one, but it felt to me like the videos section should be at the end of the article, not at the beginning. But happy to discuss pros and cons of this.

@opbld32
Copy link
Copy Markdown

opbld32 commented Sep 13, 2022

Docs Build status updates of commit 74ded91:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/customize/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/index-images/customize-devtools.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/index-images/learn-devtools-ui.png ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link
Copy Markdown

opbld33 commented Sep 13, 2022

Docs Build status updates of commit 653246f:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/customize/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/index-images/customize-devtools.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/index-images/learn-devtools-ui.png ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mikehoffms
Copy link
Copy Markdown
Collaborator Author

@captainbrosset - I copied, not linked to, the pngs.

Now that you've seen the UX with h2 at top of article, this commit instead shows you the h2 at bottom of article - keep at bottom?

@captainbrosset
Copy link
Copy Markdown
Contributor

Now that you've seen the UX with h2 at top of article, this commit instead shows you the h2 at bottom of article - keep at bottom?

Yes, I think I prefer keeping the videos at the bottom of the page. The reason for this is the section is quite long. On my monitor it takes the full height of the browser window and, therefore, makes the actual doc content not visible unless I scroll down.

If we had a way to display these videos as a much smaller, and maybe visually different, section then I'd be ok to keep them at the top.

I want to make sure readers can see the content of the documentation right away. To me, the videos are similar to "see also" content.

@captainbrosset captainbrosset merged commit b30343d into MicrosoftDocs:main Sep 13, 2022
@mikehoffms mikehoffms deleted the user/mikehoffms/custui-vid branch September 13, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants