Add fixes from libc-test results#9
Conversation
| pub st_blksize: blksize_t, | ||
| pub st_blocks: blkcnt_t, | ||
| pub st_spare4: [::c_long; 2usize], | ||
| } |
There was a problem hiding this comment.
This change was kinda invasive, I could swap it out for a few #[cfg()] instead, but unfortunately it seems s! is incompatible with cfg_if! (which would otherwise be more readable).
There was a problem hiding this comment.
I was trying to see if this is fixable, but it would require something like https://docs.rs/eager.
|
I'm waiting on resolution of this comment, but otherwise the PR looks good: |
See my response there, I think we can leave it as-is for now. Looking at other modules in pub st_atime: ::time_t,
pub st_atime_nsec: ::c_long, |
Complement to #8
I think we can merge this to
master, but the other PR should probably have its own branch as we won't want to upstream most of the testing changes there.Also, I took some liberties with the
cfg_if!so if you think there are better conventions I can use then feel free to comment as needed.