Skip to content

chore: mark @metamask/snaps-controllers peer dependency bump as breaking in CHANGELOG#5267

Merged
cryptodev-2s merged 2 commits intomainfrom
cryptodev2s/fix-snaps-packages-bump-changelogs
Feb 4, 2025
Merged

chore: mark @metamask/snaps-controllers peer dependency bump as breaking in CHANGELOG#5267
cryptodev-2s merged 2 commits intomainfrom
cryptodev2s/fix-snaps-packages-bump-changelogs

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 4, 2025

Explanation

This PR adds the missing breaking change keyword to the changelog entry for the @metamask/snaps-controllers peer dependency bump, which was overlooked in PR #5265.

References

Changelog

See CHANGELOG for changes

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@cryptodev-2s cryptodev-2s requested review from a team as code owners February 4, 2025 16:40
@cryptodev-2s cryptodev-2s changed the title chore: mark @metamask/snaps-controllers bump CHANGELOG entry as breaking chore: mark @metamask/snaps-controllers peer dependency bump as breaking in CHANGELOG Feb 4, 2025
@cryptodev-2s cryptodev-2s self-assigned this Feb 4, 2025
@cryptodev-2s cryptodev-2s added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Feb 4, 2025
@cryptodev-2s cryptodev-2s requested a review from mcmire February 4, 2025 16:41
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@cryptodev-2s cryptodev-2s enabled auto-merge (squash) February 4, 2025 16:53
@cryptodev-2s cryptodev-2s merged commit 69da3e6 into main Feb 4, 2025
127 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/fix-snaps-packages-bump-changelogs branch February 4, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants