Conversation
MajorLift
left a comment
There was a problem hiding this comment.
Added entries for controller-utils bumps.
It would also be nice to note the controller-utils bump in the PR description. It would be very helpful to future changelog writers releasing packages that updated their controller-utils versions in this pr but were not part of this release.
|
Looks like the lockfile needs an update. Otherwise LGTM! |
216f727 to
4d1a54e
Compare
|
Thanks a lot for your input @MajorLift |
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
|
The controller-utils bump entry in the signature-controller changelog also needs to be restored. You might need to refresh the page to see the updates in this thread above. |
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/controller-utils` from `^11.2.0` to `^11.3.0` ([#4688](https://github.com/MetaMask/core/pull/4688)) |
There was a problem hiding this comment.
Apologies for the hassle, but we'll need to add the change log entries for the startup fixes also, thanks!
|
We decided to close this and create new one with @Mrtenz |
## Explanation Add optional `afterAdd` hook to mutate transactions added via `addTransaction` method. Persist original transaction params in new `txParamsOriginal` property. ## References Fixes [#4688](MetaMask/MetaMask-planning#4688) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Explanation
This PR is release candidate for v202.0.0
Changelog
Changes
Bumped
@metamask/controller-utilsto^11.3.0for following packages@metamask/address-book-controller@metamask/assets-controller@metamask/ens-controller@metamask/gas-fee-controller@metamask/logging-controller@metamask/message-manager@metamask/name-controller@metamask/network-controller@metamask/notification-services-controller@metamask/permissions-controller@metamask/polling-controller@metamask/preferences-controller@metamask/polling-controller@metamask/queued-request-controller@metamask/user-operation-controller@metamask/transaction-controller@metamask/signature-controllerChanges for
@metamask/transaction-controllerTransactionController, instead import them from@metamask/controller-utils(#4655)Changes for
@metamask/signature-controllertracecallback to constructor.traceContextoption tonewUnsignedPersonalMessageandnewUnsignedTypedMessagemethods.Checklist