Merged
Conversation
danroc
approved these changes
Jan 13, 2025
4 tasks
ccharly
added a commit
to MetaMask/core
that referenced
this pull request
Jan 13, 2025
…eature (#5136) ## Explanation Some accounts packages were not properly versioned when introducing the new `scopes` feature. This has now been fixed and this PR bumps each accounts packages accordingly. ## References - #5066 - MetaMask/accounts#137 - MetaMask/accounts#133 ## Changelog ### `@metamask/accounts-controller` - **CHANGED**: **BREAKING:** Bump `keyring-internal-api` to `^2.0.0` - **CHANGED**: **BREAKING:** Bump `eth-snap-keyring` to `^8.0.0` ### `@metamask/chain-controller` - **CHANGED**: **BREAKING:** Bump `keyring-internal-api` to `^2.0.0` ### `@metamask/keyring-controller` - **CHANGED**: **BREAKING:** Bump `keyring-internal-api` to `^2.0.0` ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the release candidate for version 18.0.0. See the CHANGELOGs for more details.
There was a previous attempt for this release that didn't get through because of the top-level package bump that was missing, see:
Warning
The previous version 17.0.0 did not report some breaking changes properly. This new version is just meant to re-align the CHANGELOGs and to fix the versioning.