This repository was archived by the owner on Nov 28, 2024. It is now read-only.
Report on the success to git credential#61
Merged
mergify[bot] merged 2 commits intoMergifyio:masterfrom May 9, 2019
Merged
Conversation
f18d222 to
978a5b7
Compare
This tells git credential that the password worked and that it can be re-used.
jd
approved these changes
May 9, 2019
Member
|
Thanks for confirming this, I was not sure it was needed :) |
Contributor
Author
|
You're welcome. IIUC, the approve action triggers the cache store request. Another improvement would be to except authentication failure and report the reject action to trigger the cache erase request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tells git credential that the password worked and that it can be re-used.