Rename function factories create_cut() and create_test()#221
Merged
Conversation
Collaborator
|
Concept is great. I have not reviewed code or tests. |
LittleBeannie
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @jdblischak ! I only have 1 minor comment.
nanxstats
suggested changes
Mar 25, 2024
nanxstats
approved these changes
Mar 25, 2024
nanxstats
left a comment
Contributor
There was a problem hiding this comment.
OK let's get this merged! I appreciate the simplification efforts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #201 and #215.
Based on our internal discussion on how to name these functions, I propose renaming the function factories
create_cut()andcreate_test(), and renaming their correspondingsim_gs_n()arguments tocutscutandteststest.