Skip to content

Add snapshot test for sim_gs_n() with milestone() test#212

Merged
nanxstats merged 1 commit into
Merck:mainfrom
jdblischak:snapshot-test-milestone
Mar 7, 2024
Merged

Add snapshot test for sim_gs_n() with milestone() test#212
nanxstats merged 1 commit into
Merck:mainfrom
jdblischak:snapshot-test-milestone

Conversation

@jdblischak
Copy link
Copy Markdown
Collaborator

Follow-up to #204

  • Created a snapshot test of the new example of sim_gs_n() + milestone()
  • Regenerated the docs for sim_gs_n()

@jdblischak jdblischak self-assigned this Mar 6, 2024
@jdblischak
Copy link
Copy Markdown
Collaborator Author

I missed #211. Let's merge that one first and then I'll update this one as needed

@jdblischak jdblischak marked this pull request as draft March 6, 2024 21:06
@jdblischak jdblischak force-pushed the snapshot-test-milestone branch from f842381 to 76288a1 Compare March 7, 2024 01:57
@jdblischak
Copy link
Copy Markdown
Collaborator Author

Updated for #211. Now waiting on #213

@jdblischak jdblischak force-pushed the snapshot-test-milestone branch from 76288a1 to 55347a2 Compare March 7, 2024 02:17
@jdblischak jdblischak marked this pull request as ready for review March 7, 2024 02:18
@jdblischak
Copy link
Copy Markdown
Collaborator Author

Rebased on #213. Ready for review

Copy link
Copy Markdown
Contributor

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Essential addition ✨

@nanxstats nanxstats merged commit c638370 into Merck:main Mar 7, 2024
@jdblischak jdblischak deleted the snapshot-test-milestone branch March 7, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants