Skip to content

fix: Coerce ProjectItems field id to string for schema validation#587

Merged
edgarrmondragon merged 2 commits into
MeltanoLabs:mainfrom
josephwibowo:fix/project-items-field-id-string
Jul 1, 2026
Merged

fix: Coerce ProjectItems field id to string for schema validation#587
edgarrmondragon merged 2 commits into
MeltanoLabs:mainfrom
josephwibowo:fix/project-items-field-id-string

Conversation

@josephwibowo

@josephwibowo josephwibowo commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Coerce GraphQL databaseId to str when copying field values in ProjectItemsStream.post_process
  • Fixes jsonschema validation failures for title.id, status.id, and field_values[].id, which are declared string|null but were receiving integer values from GraphQL
  • Minimal change: only id is coerced when present; other copied keys are unchanged

Fixes #514

Test plan

  • uv run mypy tap_github passes
  • uv run pytest

GraphQL databaseId arrives as an int but title.id and field_values[].id
are declared string|null, causing jsonschema validation failures after
stricter SDK type checking in v1.26.0.

Fixes MeltanoLabs#514

Co-authored-by: Cursor <cursoragent@cursor.com>
@josephwibowo josephwibowo requested a review from a team as a code owner June 22, 2026 22:48
@edgarrmondragon edgarrmondragon self-assigned this Jun 22, 2026
@edgarrmondragon edgarrmondragon changed the title fix: coerce ProjectItems field id to string for schema validation fix: Coerce ProjectItems field id to string for schema validation Jul 1, 2026
@edgarrmondragon edgarrmondragon added this pull request to the merge queue Jul 1, 2026
Merged via the queue into MeltanoLabs:main with commit c8b013a Jul 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProjectItemsStream is returning an integer for id field instead of a string

2 participants