Changed wp_get_the_category() to wp_get_post_categories() #115
Open
davpsh wants to merge 1 commit intoMedium:masterfrom
davpsh:issue-#114
Open
Changed wp_get_the_category() to wp_get_post_categories() #115davpsh wants to merge 1 commit intoMedium:masterfrom davpsh:issue-#114
davpsh wants to merge 1 commit intoMedium:masterfrom
davpsh:issue-#114
Conversation
Added comment for wp_get_post_categories()
lacqui
approved these changes
Oct 5, 2016
lacqui
left a comment
There was a problem hiding this comment.
I've done some local testing and this appears to work for me.
nciske
approved these changes
Oct 31, 2016
majelbstoat
reviewed
May 16, 2017
| } | ||
| $tags = array_values(array_unique(array_merge($cats, $tags))); | ||
| $args = array('fields' => 'names'); // @see wp_get_post_categories() $args ref to wp_get_object_terms() | ||
| $categories_name = wp_get_post_categories($post->ID, $args); |
Contributor
There was a problem hiding this comment.
$category_names, or just $cats
majelbstoat
reviewed
May 16, 2017
| $cats[] = $category->name; | ||
| } | ||
| $tags = array_values(array_unique(array_merge($cats, $tags))); | ||
| $args = array('fields' => 'names'); // @see wp_get_post_categories() $args ref to wp_get_object_terms() |
Contributor
There was a problem hiding this comment.
double quotes, as the rest of this plugin please, even though it's not WP-standard.
|
Did some testing and it works for me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#114 Added comment for wp_get_post_categories()