Skip to content

Procedurally generate the inputrc files#21

Closed
GarkGarcia wants to merge 6 commits intomasterfrom
procedural-inputrc
Closed

Procedurally generate the inputrc files#21
GarkGarcia wants to merge 6 commits intomasterfrom
procedural-inputrc

Conversation

@GarkGarcia
Copy link
Contributor

This is a follow up to #16 (comment). I've noticed there are yet more errors in the translation tables (in the ESC alias column specifically). I'll go over those before we merge this.

@GarkGarcia GarkGarcia added the enhancement New feature or request label Jan 26, 2021
@GarkGarcia GarkGarcia requested a review from rocky January 26, 2021 17:06
@GarkGarcia
Copy link
Contributor Author

I've noticed there are yet more errors in the translation tables (in the ESC alias column specifically). I'll go over those before we merge this.

I've fixed the ones I could find in Mathics3/mathics-scanner@fd335e7.

@GarkGarcia
Copy link
Contributor Author

@rocky I don't know whats the best place to run the code that generates the files, feel free to change it if you feel like so.

@rocky rocky force-pushed the procedural-inputrc branch from b8780fb to fe14c7e Compare February 6, 2021 21:32
@rocky rocky changed the base branch from master to use-mathics-scanner-release February 6, 2021 21:33
Copy link
Member

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redone now that the inputrc generation file has moved to mathics-scanner

@rocky rocky force-pushed the procedural-inputrc branch from fe14c7e to 91b0d3e Compare February 6, 2021 21:55
@rocky rocky changed the base branch from use-mathics-scanner-release to master February 6, 2021 22:05
@rocky
Copy link
Member

rocky commented Feb 14, 2021

Has been merged via rc1 into master.

@rocky rocky closed this Feb 14, 2021
@rocky rocky deleted the procedural-inputrc branch March 19, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants