Skip to content

Comments

Mathics scanner import#13

Merged
rocky merged 2 commits intomasterfrom
mathics-scanner-import
Jan 23, 2021
Merged

Mathics scanner import#13
rocky merged 2 commits intomasterfrom
mathics-scanner-import

Conversation

@GarkGarcia
Copy link
Contributor

The same as mathics/Mathics#1117 but for mathicsscript.

@GarkGarcia GarkGarcia added the enhancement New feature or request label Jan 19, 2021
@GarkGarcia GarkGarcia requested a review from rocky January 19, 2021 15:50
@GarkGarcia GarkGarcia marked this pull request as draft January 19, 2021 15:50
@GarkGarcia
Copy link
Contributor Author

@rocky I still haven't figured out where is the code that prints runtime warnings. We should wrap it with replace_wl_with_plain_text.

@GarkGarcia
Copy link
Contributor Author

I also have no idea why this is falling to install. I tried copying what @rocky did in mathics/Mathics#1117 but I got something wrong.

@rocky rocky marked this pull request as ready for review January 23, 2021 02:41
@rocky
Copy link
Member

rocky commented Jan 23, 2021

I am not sure why CI isn't running. Will merge though and we can come back and fix up the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants