Add builtin just once#620
Closed
mmatera wants to merge 24 commits intofix_definition_autoload_to_builtinfrom
Closed
Add builtin just once#620mmatera wants to merge 24 commits intofix_definition_autoload_to_builtinfrom
mmatera wants to merge 24 commits intofix_definition_autoload_to_builtinfrom
Conversation
…ay from the conditional.
improving clarity in Builtin.contribute
Adding comments and tests for Assignment
symbols.py: system_symbols() -> symbol_set(); "systems_symbols" name is too close Symbol( System` to module systemsymbols. Also, we now require symbols as parameters), not strings. systemsymbols.py: more system symbols
It appears this was originally Pattern.create. I suspect due to bad modularity and a lack of understandig Python that an import could be added inside the routine, this static method got moved outside of the class. Later on, the modularity was fixed, but the hack persisted. These kinds of code smells side effects of poor communication.
wehn it gets fixed.
improve `OneIdentity` builtin
* More apply() -> eval() cutovers in the changed files * Some <dt> indentation regularization. * DRY redundant "argr" message definitions
Add SetAttributes length check and ...
Member
|
As i mentioned in another PR, let me suggest some code and you can review. Thanks. |
Contributor
Author
|
Ok. This was just to illustrate the point. |
Member
Ok. My takeaway with this is that there is some misunderstanding. |
Contributor
|
@mmatera just 2 Git tips:
|
Contributor
Author
@TiagoCavalcante thanks, and sorry for the noise. In any case, my mistake here was to put this in a PR instead of just cite the branch in the parent PR. The aim of this was just to understand @rocky 's idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is one possible implementation for the @rocky 's idea that builtins (and autoload modules) should be loaded just once.