Improve error handling in benchmarks#6675
Merged
cirego merged 1 commit intoMay 7, 2021
Merged
Conversation
If we fail to create views, or if any kgen process exits with error, then we know the benchmark won't be valid. Ensure that we exit with error to make sure that the benchmark fails at the right point instead of timing out or presenting another inscrutable error.
aljoscha
approved these changes
May 7, 2021
Contributor
aljoscha
left a comment
There was a problem hiding this comment.
This makes a lot of sense. Thanks for the changes!
I had one inline question.
|
|
||
| for view_file in *.sql; do | ||
| psql -h perf-dash-metrics -p 8675 -U materialize -f "${view_file}" materialize | ||
| psql -v ON_ERROR_STOP=1 -h perf-dash-metrics -p 8675 -U materialize -f "${view_file}" materialize |
Contributor
There was a problem hiding this comment.
Will this also make the scripts exit with 1 or does it just stop psql on the first error it encouters?
Contributor
Author
There was a problem hiding this comment.
Both the script and mzcompose will also exit with error!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we fail to create views, or if any kgen process exits with
error, then we know the benchmark won't be valid. Ensure that
we exit with error to make sure that the benchmark fails at the
right point instead of timing out or presenting another inscrutable
error.