audit: add missing audit log entry for ALTER TABLE ADD COLUMN#36449
Open
def- wants to merge 3 commits into
Open
audit: add missing audit log entry for ALTER TABLE ADD COLUMN#36449def- wants to merge 3 commits into
ALTER TABLE ADD COLUMN#36449def- wants to merge 3 commits into
Conversation
cda2efc to
a54c295
Compare
The `Op::AlterAddColumn` handler was missing an audit log entry, unlike every other ALTER operation. This adds an `AlterAddColumnV1` event that records the table ID, column name, column type, and nullability. Introduced in MaterializeInc#30470. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
a54c295 to
3cf5c0c
Compare
ALTER TABLE ADD COLUMN
…ERVAL) `Op::AlterSourceTimestampInterval` previously updated the catalog item without writing to `mz_audit_events`, leaving an observability/compliance gap for a change that materially affects ingestion latency. Mirror the `AlterRetainHistory` shape: add an `AlterSourceTimestampIntervalV1` event variant (id, old_interval, new_interval), have `CatalogItem::update_timestamp_interval` return the previous value, and call `add_to_audit_log` from the op handler. The new variant rides on the existing v82 -> v83 migration alongside `AlterAddColumnV1`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Op::AlterAddColumnhandler was missing an audit log entry, unlike every other ALTER operation. This adds anAlterAddColumnV1event that records the table ID, column name, column type, and nullability.Introduced in #30470.
Nightly: https://buildkite.com/materialize/nightly/builds/16364