adapter: refactor select to sequence staged#27693
Merged
Merged
Conversation
ParkMyCar
approved these changes
Jun 17, 2024
Contributor
ParkMyCar
left a comment
There was a problem hiding this comment.
This looks fantastic, thank you for refactoring peeks to the framework!
This required changing the RTR and ActiveCopyTo APIs to no longer take full ownership of the `ExecuteContext`. In the RTR case, this was the last usage of that API and it could be removed completely.
def-
added a commit
to def-/materialize
that referenced
this pull request
May 8, 2026
The staged sequencer refactor propagated RtrTimeout and RtrDropFailure as generic StorageError, losing the humanized display, detail text, and correct SQL state (QUERY_CANCELED / UNDEFINED_OBJECT). Convert them to the dedicated AdapterError variants before propagating. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
def-
added a commit
to def-/materialize
that referenced
this pull request
May 8, 2026
The staged sequencer refactor propagated RtrTimeout and RtrDropFailure as generic StorageError, losing the humanized display, detail text, and correct SQL state (QUERY_CANCELED / UNDEFINED_OBJECT). Convert them to the dedicated AdapterError variants before propagating. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
def-
added a commit
to def-/materialize
that referenced
this pull request
May 9, 2026
The staged sequencer refactor propagated RtrTimeout and RtrDropFailure as generic StorageError, losing the humanized display, detail text, and correct SQL state (QUERY_CANCELED / UNDEFINED_OBJECT). Convert them to the dedicated AdapterError variants before propagating. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
def-
added a commit
that referenced
this pull request
May 13, 2026
The staged sequencer refactor propagated RtrTimeout and RtrDropFailure as generic StorageError, losing the humanized display, detail text, and correct SQL state (QUERY_CANCELED / UNDEFINED_OBJECT). Convert them to the dedicated AdapterError variants before propagating. lost in #27693 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required changing the RTR and ActiveCopyTo APIs to no longer take full ownership of the
ExecuteContext. In the RTR case, this was the last usage of that API and it could be removed completely.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.