Skip to content

ID and Radio Button Fixes in the Layer Control #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prushforth merged 2 commits into from
Oct 28, 2021
Merged

ID and Radio Button Fixes in the Layer Control #548

prushforth merged 2 commits into from
Oct 28, 2021

Conversation

@Anshpreet8
Copy link
Contributor

@Anshpreet8 Anshpreet8 commented Oct 28, 2021

  • Fixed the duplicate IDs in the layer style control
  • Fixed an issue with the radio button, under the layer styles control, where only one radio button could be selected from all layers
  • Removed whitespace from ID in the layer control

Closes #508

@Malvoz
Copy link
Member

Malvoz commented Oct 28, 2021

Looks good, thanks!

prushforth
prushforth approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like magic.

@prushforth prushforth merged commit e8132d4 into Maps4HTML:main Oct 28, 2021
@Anshpreet8 Anshpreet8 deleted the layerControlFixes branch November 23, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prushforth prushforth prushforth approved these changes

@Malvoz Malvoz Malvoz approved these changes

@ahmadayubi ahmadayubi ahmadayubi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect ID references in layer control

4 participants

@Anshpreet8 @Malvoz @prushforth @ahmadayubi