Skip to content

native-like styles for interactive features #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prushforth merged 4 commits into from
Jul 20, 2021
Merged

native-like styles for interactive features #478

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba9c3bc
native-like styles for interactive features
Malvoz Jun 25, 2021
769e145
Use `LinkText` system color (if supported) to highlight interactive f…
Malvoz Jun 26, 2021
bc604f0
Remove `.mapml-vector-container` scope for feature styles
Malvoz Jun 30, 2021
bd668e8
Use `#0000EE` fallback color for interactive features
Malvoz Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions src/mapml/layers/FeatureLayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,23 @@ export var MapMLFeatures = L.FeatureGroup.extend({
// info: https://github.com/Leaflet/Leaflet/pull/4597
L.DomUtil.addClass(this._container, 'leaflet-pane mapml-vector-container');
L.setOptions(this.options.renderer, {pane: this._container});
let anim = L.DomUtil.create("style", "mapml-feature-animation", this._container);
anim.innerHTML = `@keyframes pathSelect {
0% {stroke: white;}
50% {stroke: black;}
}
g:focus > path,
path:focus {
animation-name: pathSelect;
animation-duration: 1s;
stroke-width: 5;
stroke: black;
let style = L.DomUtil.create("style", "mapml-feature-style", this._container);
style.innerHTML = `
g[role="link"]:focus,
g[role="link"]:hover,
g[role="button"]:focus,
g[role="button"]:hover,
g[role="link"] path:focus,
g[role="link"] path:hover,
g[role="button"] path:focus,
g[role="button"] path:hover,
g[role="link"]:focus path,
g[role="link"]:hover path,
g[role="button"]:focus path,
g[role="button"]:hover path {
outline: 0!important;
stroke: #0000EE;
stroke: LinkText;
}`;
}

Expand Down Expand Up @@ -310,7 +316,7 @@ export var MapMLFeatures = L.FeatureGroup.extend({
_removeCSS: function(){
let toDelete = this._container.querySelectorAll("link[rel=stylesheet],style");
for(let i = 0; i < toDelete.length;i++){
if(toDelete[i].classList.contains("mapml-feature-animation")) continue;
if(toDelete[i].classList.contains("mapml-feature-style")) continue;
this._container.removeChild(toDelete[i]);
}
},
Expand Down