Skip to content

feat: pixel size validation #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nitzanmorr wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

feat: pixel size validation #163

nitzanmorr wants to merge 15 commits into from

Conversation

@nitzanmorr
Copy link
Contributor

@nitzanmorr nitzanmorr commented Aug 13, 2024

Question Answer
Bug fix ✖
New feature ✔
Breaking change ✖
Deprecations ✖
Documentation ✖
Tests added ✔
Chore ✖

Related issues: #XXX , #XXX ...
Closes #XXX ...

Further information:

shimoncohen and others added 13 commits June 4, 2024 22:29
@shimoncohen
refactor(TileMerger): pass uploadOnly and skip merge in case there is…
dfae62e 
… only one source
@nitzanmorr
chore: added image dimensions validation function including tests
b039cf7
@shimoncohen
chore: remove duplicate section in upload only condition
9107aae
@shimoncohen
chore(TileMerger): add logs for upload only mode
6be489f
@nitzanmorr
Merge branch 'add-upload-only-mode-to-merge-tiles' of github.com:MapC…
04f1500 
…olonies/GpkgMerger into pixel-size-validation
@nitzanmorr
chore: added height and width attributes to Tile
b1c090f
@nitzanmorr
test: modified all tests to work on actual images instead of bytes
bfabebc
@nitzanmorr
test: fixed the tests that uses data row
61da9e5
@nitzanmorr
test: moved the tests to TileTest
cc48e8e
@nitzanmorr
chore: moved the tile size validation to Tile class and added allowed…
73bef7c 
…Size config
@nitzanmorr
feat: addded pixel size validation to the Tile constructor itself
b42561a
@nitzanmorr
test: modified tests to use actual images
72d92c9
@nitzanmorr
Merge branch 'master' of github.com:MapColonies/GpkgMerger into pixel…
2b41885 
…-size-validation
@nitzanmorr nitzanmorr self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nitzanmorr nitzanmorr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitzanmorr @shimoncohen