Skip to content

Activity indicator new examples#139

Merged
AnshG714 merged 3 commits intorntest-pkgfrom
activity-indicator-new-examples
Jul 9, 2020
Merged

Activity indicator new examples#139
AnshG714 merged 3 commits intorntest-pkgfrom
activity-indicator-new-examples

Conversation

@AnshG714
Copy link
Copy Markdown

@AnshG714 AnshG714 commented Jul 7, 2020

This PR adds new cases, or reworks the existing ones, to account for more 'real-life' scenarios.
Some examples include:

  • Adding a 'Loading' text field near the activity indicator which is commonly seen with this component
  • Removing redundant examples which simply combine different props without really adding more value to the app
  • Adding a new button-toggled activity indicator which uses a prop that was not included in the original examples.

@AnshG714 AnshG714 self-assigned this Jul 7, 2020
@AnshG714
Copy link
Copy Markdown
Author

AnshG714 commented Jul 7, 2020

Edit: Don't review it right now. I don't know why my changes aren't showing here.

anku255
anku255 previously approved these changes Jul 8, 2020
@anku255 anku255 dismissed their stale review July 8, 2020 11:38

Reviewed by mistake

@AnshG714 AnshG714 merged commit 195939a into rntest-pkg Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants