Skip to content

Fixed a bug on pi_inf and enabled subgrid bubble model for viscous flow#151

Merged
sbryngelson merged 12 commits into
MFlowCode:masterfrom
hyeoksu-lee:master
May 8, 2023
Merged

Fixed a bug on pi_inf and enabled subgrid bubble model for viscous flow#151
sbryngelson merged 12 commits into
MFlowCode:masterfrom
hyeoksu-lee:master

Conversation

@hyeoksu-lee
Copy link
Copy Markdown
Contributor

@hyeoksu-lee hyeoksu-lee commented May 1, 2023

  1. Fixed a bug that the capital 'pi_inf' was used where the little 'pi_inf' should be used. Also, computing speed of sound is also corrected.

  2. Enabled subgrid bubble model for viscous flow

    • Added codes that computes the Reynolds number properly when 'bubbles=T'
  3. Modified codes to make 'vel_profile' and 'instability_wave' options compatible with 'bubbles=T' and 'num_fluids=1'

  4. Changed grid numbers in example/3D_turb_mixing to prevent memory issue (3d_turb_mixing not working #149)

hyeoksu-lee and others added 5 commits May 1, 2023 11:48
@anandrdbz
Copy link
Copy Markdown
Contributor

These changes seem fine, you might wanna change the definition of B_tait in m_qbmm as well. Other than that everything looks fine. The tests won't pass as of now due to this change as the golden files need to be regenerated for this definition of pi-inf

@sbryngelson
Copy link
Copy Markdown
Member

Thanks for looking @anandrdbz . Agreed @lee-hyeoksu you'll have to generate new golden files for the test cases involving sub-grid bubbles. I believe this is documented, but you can also look through the toolchain/ code to see how this is done.

@sbryngelson sbryngelson added the bug Something isn't working or doesn't seem right label May 4, 2023
@sbryngelson sbryngelson linked an issue May 4, 2023 that may be closed by this pull request
@hyeoksu-lee hyeoksu-lee requested a review from henryleberre as a code owner May 4, 2023 19:16
@hyeoksu-lee
Copy link
Copy Markdown
Contributor Author

Thanks @anandrdbz and @sbryngelson. The definition of B_tait in m_qbmm is now changed, and the golden files for the cases with sub-grid bubbles are updated.

@sbryngelson
Copy link
Copy Markdown
Member

@lee-hyeoksu your PR is failing GPU tests on the bubble cases I think.

@hyeoksu-lee
Copy link
Copy Markdown
Contributor Author

@sbryngelson The failure on GPU was because I didn't add Re_L and Re_R to the private clause for OpenACC when I added codes for computing Re_L and Re_R in m_riemann_solvers. Now it is fixed.

@sbryngelson
Copy link
Copy Markdown
Member

Great, thanks @lee-hyeoksu ! Can you also add new tests for the case of viscous effects + subgrid bubbles? So we can track if code associated with those effects changes or breaks. Again, there should be some documentation on this (adding new tests).

@hyeoksu-lee
Copy link
Copy Markdown
Contributor Author

hyeoksu-lee commented May 6, 2023

@sbryngelson I added new tests, and they appear in the list by ./mfc.sh test -l. But is there anywhere else I should add documentation?

@sbryngelson sbryngelson merged commit 1e101a5 into MFlowCode:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working or doesn't seem right

Development

Successfully merging this pull request may close these issues.

3d_turb_mixing not working

3 participants