Fixed a bug on pi_inf and enabled subgrid bubble model for viscous flow#151
Conversation
…bubble models for viscous flow
merge from MFCmerge from MFCmerge from MFCmerge from MFCmerge from MFCmerge from MFCmerge from MFCmerge from MFCmerge from MFC
|
These changes seem fine, you might wanna change the definition of B_tait in m_qbmm as well. Other than that everything looks fine. The tests won't pass as of now due to this change as the golden files need to be regenerated for this definition of pi-inf |
|
Thanks for looking @anandrdbz . Agreed @lee-hyeoksu you'll have to generate new golden files for the test cases involving sub-grid bubbles. I believe this is documented, but you can also look through the |
|
Thanks @anandrdbz and @sbryngelson. The definition of |
|
@lee-hyeoksu your PR is failing GPU tests on the bubble cases I think. |
|
@sbryngelson The failure on GPU was because I didn't add |
|
Great, thanks @lee-hyeoksu ! Can you also add new tests for the case of viscous effects + subgrid bubbles? So we can track if code associated with those effects changes or breaks. Again, there should be some documentation on this (adding new tests). |
|
@sbryngelson I added new tests, and they appear in the list by |
Fixed a bug that the capital 'pi_inf' was used where the little 'pi_inf' should be used. Also, computing speed of sound is also corrected.
Enabled subgrid bubble model for viscous flow
Modified codes to make 'vel_profile' and 'instability_wave' options compatible with 'bubbles=T' and 'num_fluids=1'
Changed grid numbers in example/3D_turb_mixing to prevent memory issue (
3d_turb_mixingnot working #149)