cmake: replace -fopenmp-target-fast with -O3 for LLVMFlang AMD GPU builds#1450
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1450 +/- ##
=======================================
Coverage 61.31% 61.31%
=======================================
Files 72 72
Lines 19771 19771
Branches 2852 2852
=======================================
Hits 12123 12123
Misses 5699 5699
Partials 1949 1949 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
-fopenmp-target-fastwith-O3in the LLVMFlang OpenMP target offload compile flags.-fopenmp-target-fastis present in the minimal reproducer for the array constructor corruption bug reported in #1449. Replacing it with explicit-O3preserves optimization level while avoiding the flag combination that triggers silent wrong values inGPU_PARALLEL_LOOPregions on AMD MI250X (gfx90a).Closes #1449
Test plan
./mfc.sh build --gpu mp -j 8on Frontier using AMD flang./mfc.sh test --only IBM -j 8) and confirm ghost point corrections are correct