Implement Khan and Reversed DFS Post Order algorithms#4202
Closed
FiasKr wants to merge 1 commit intoLuckPerms:masterfrom
Closed
Implement Khan and Reversed DFS Post Order algorithms#4202FiasKr wants to merge 1 commit intoLuckPerms:masterfrom
FiasKr wants to merge 1 commit intoLuckPerms:masterfrom
Conversation
Member
|
Do you have a use for this? Can you give an example (in context) where this is useful in LuckPerms with groups? |
Author
I was just trying to resolve this fairly old issue: #3361 |
Member
|
Ok, thank you nonetheless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new algorithms for traversing the inheritance graph: Khan's algorithm and a reversed DFS post-order traversal. Both are topological sort algorithms that can be used to determine the order of inheritance (#3361).
Changes
common/src/main/java/me/lucko/luckperms/common/graph/TraversalAlgorithm.javaREVERSED_DFS_POSTto theTraversalAlgorithmenum. This algorithm provides a topological sort by reversing the result of a depth-first post-order traversal.KHANto theTraversalAlgorithmenum. This is an implementation of Khan's algorithm for topological sorting.common/src/test/java/me/lucko/luckperms/common/model/InheritanceTest.javaREVERSED_DFS_POSTandKHANto the parameterized testtestInheritanceTree.testKhanAlgorithmto specifically test the Khan's algorithm implementation.testReversedDfsPostAlgorithmto specifically test the reversed DFS post-order algorithm.