⚡ Optimize chromium bookmark parsing by avoiding generic JSON allocations#147
⚡ Optimize chromium bookmark parsing by avoiding generic JSON allocations#147Lucenx9 wants to merge 10 commits into
Conversation
By transitioning from `serde_json::Value` (which dynamically allocates every key and nested object) to strongly-typed structs (`BookmarkFile`, `BookmarkNode`), we skip allocating memory for metadata fields we don't care about (e.g. `date_added`, `guid`, `meta_info`). A Criterion benchmark showed a massive performance gain: Baseline (`serde_json::Value`): ~12.280 ms Optimized (Struct Deserialization): ~5.0129 ms This represents a ~59% performance improvement and vastly reduced memory allocations when importing massive browser bookmark files. Used `BTreeMap` to maintain deterministic sorting order. Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 19 minutes and 1 second. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
By transitioning from `serde_json::Value` (which dynamically allocates every key and nested object) to strongly-typed structs (`BookmarkFile`, `BookmarkNode`), we skip allocating memory for metadata fields we don't care about (e.g. `date_added`, `guid`, `meta_info`). A Criterion benchmark showed a massive performance gain: Baseline (`serde_json::Value`): ~12.280 ms Optimized (Struct Deserialization): ~5.0129 ms This represents a ~59% performance improvement and vastly reduced memory allocations when importing massive browser bookmark files. Used `BTreeMap` to maintain deterministic sorting order. Also fixed unrelated fmt issues. Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
By transitioning from `serde_json::Value` (which dynamically allocates every key and nested object) to strongly-typed structs (`BookmarkFile`, `BookmarkNode`), we skip allocating memory for metadata fields we don't care about (e.g. `date_added`, `guid`, `meta_info`). A Criterion benchmark showed a massive performance gain: Baseline (`serde_json::Value`): ~12.280 ms Optimized (Struct Deserialization): ~5.0129 ms This represents a ~59% performance improvement and vastly reduced memory allocations when importing massive browser bookmark files. Used `BTreeMap` to maintain deterministic sorting order. Also fixed unrelated fmt issues. Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
💡 What:
Replaced dynamically-typed
serde_json::Valueparsing incrates/forktty-import/src/history.rs(read_chromium_bookmarks) with strongly-typed Serde structs (BookmarkFile,BookmarkNode). Re-implemented the parsing graph to safely walk over the new structs without altering the bounding limits or structure of the returned objects.🎯 Why:
Parsing massive Chromium bookmark files using
serde_json::Valuegenerically allocates memory for every single node in the file. Chromium injects a huge amount of metadata into these files (likeguid,date_added,date_modified,meta_info). By strongly typing the target using structs that useOption, Serde can ignore that vast amount of unused metadata and instantiate only what we strictly care about.BTreeMapwas chosen for therootsfield to guarantee deterministic parsing.📊 Measured Improvement:
Before the change, a synthetic benchmark with a 10,000 node JSON file using Criterion measured:
After applying the optimization, the same benchmark measured:
Change over baseline: A ~59% speed improvement, primarily bounded by removing significant generic heap allocation pressure overhead.
PR created automatically by Jules for task 10565498353923734077 started by @Lucenx9