Skip to content

🧪 Add tests for browser history and bookmark path utilities#141

Open
Lucenx9 wants to merge 10 commits into
mainfrom
test-browser-history-paths-5426773176029655777
Open

🧪 Add tests for browser history and bookmark path utilities#141
Lucenx9 wants to merge 10 commits into
mainfrom
test-browser-history-paths-5426773176029655777

Conversation

@Lucenx9
Copy link
Copy Markdown
Owner

@Lucenx9 Lucenx9 commented Jun 2, 2026

🎯 What: The history_path and bookmarks_path utilities in browser_history.rs were missing test coverage.
📊 Coverage: Added two new test functions, test_history_path and test_bookmarks_path, verifying that the functions produce Some(PathBuf) pointing to the correct .sqlite and .json filenames within the expected directory structure (specifically containing forktty, browser_profiles, and the stringified profile id), whilst gracefully early returning on restrictive environments where dirs::data_local_dir is none.
Result: Improved overall coverage of the forktty-core crate by formally validating the history and bookmark path constructions.


PR created automatically by Jules for task 5426773176029655777 started by @Lucenx9

Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Warning

Review limit reached

@Lucenx9, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 3 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 687fba2f-9ded-4b93-b913-da61a58c7d15

📥 Commits

Reviewing files that changed from the base of the PR and between c30396c and 65c2e1a.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • crates/forktty-core/src/browser_history.rs
  • crates/forktty-core/src/config.rs
  • crates/forktty-import/src/sources.rs
  • crates/forktty-socket/src/lib.rs
  • crates/forktty-ui-gtk/src/socket_cli.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-browser-history-paths-5426773176029655777

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant