Remote 1: Action Models #1930
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| // | ||
|
Contributor
Author
There was a problem hiding this comment. I needed to update the RemoteCommandTests with these and change a few that are unnecessary. I added more tests to LoopKit, which test the individual remote action types themselves which should cover all the cases I know of. |
||
| // RemoteActionTests.swift | ||
| // LoopTests | ||
| // | ||
| // Created by Bill Gestrich on 8/13/22. | ||
| // Copyright © 2022 LoopKit Authors. All rights reserved. | ||
| // | ||
|
|
||
| import XCTest | ||
| import HealthKit | ||
| @testable import Loop | ||
| import LoopKit | ||
|
|
||
| class RemoteActionTests: XCTestCase { | ||
|
|
||
| override func setUpWithError() throws { | ||
| } | ||
|
|
||
| override func tearDownWithError() throws { | ||
| } | ||
|
|
||
|
|
||
| //MARK: Carb Entry Command | ||
|
|
||
| func testParseCarbEntryNotification_ValidPayload_Succeeds() throws { | ||
|
|
||
| //Arrange | ||
| let expectedStartDateString = "2022-08-14T03:08:00.000Z" | ||
| let expectedCarbsInGrams = 15.0 | ||
| let expectedDate = dateFormatter().date(from: expectedStartDateString)! | ||
| let expectedAbsorptionTimeInHours = 3.0 | ||
| let expectedFoodType = "🍕" | ||
| let otp = 12345 | ||
| let notification: [String: Any] = [ | ||
| "carbs-entry":expectedCarbsInGrams, | ||
| "absorption-time": expectedAbsorptionTimeInHours, | ||
| "food-type": expectedFoodType, | ||
| "otp": otp, | ||
| "start-time": expectedStartDateString | ||
| ] | ||
|
|
||
| //Act | ||
| let action = try RemoteAction.createRemoteAction(notification: notification).get() | ||
|
|
||
| //Assert | ||
| guard case .carbsEntry(let carbEntry) = action else { | ||
| XCTFail("Incorrect case") | ||
| return | ||
| } | ||
| XCTAssertEqual(carbEntry.startDate, expectedDate) | ||
| XCTAssertEqual(carbEntry.absorptionTime, TimeInterval(hours: expectedAbsorptionTimeInHours)) | ||
| XCTAssertEqual(carbEntry.amountInGrams, expectedCarbsInGrams) | ||
| XCTAssertEqual(expectedFoodType, carbEntry.foodType) | ||
| } | ||
|
|
||
| func testParseCarbEntryNotification_MissingCreatedDate_Succeeds() throws { | ||
|
|
||
| //Arrange | ||
| let expectedCarbsInGrams = 15.0 | ||
| let expectedAbsorptionTimeInHours = 3.0 | ||
| let otp = 12345 | ||
| let notification: [String: Any] = [ | ||
| "carbs-entry":expectedCarbsInGrams, | ||
| "absorption-time": expectedAbsorptionTimeInHours, | ||
| "otp": otp | ||
| ] | ||
|
|
||
| //Act | ||
| let action = try RemoteAction.createRemoteAction(notification: notification).get() | ||
|
|
||
| //Assert | ||
| guard case .carbsEntry(let carbEntry) = action else { | ||
| XCTFail("Incorrect case") | ||
| return | ||
| } | ||
|
|
||
| XCTAssertEqual(carbEntry.startDate, nil) | ||
| XCTAssertEqual(carbEntry.absorptionTime, TimeInterval(hours: expectedAbsorptionTimeInHours)) | ||
| XCTAssertEqual(carbEntry.amountInGrams, expectedCarbsInGrams) | ||
| } | ||
|
|
||
| func testParseCarbEntryNotification_InvalidCreatedDate_Fails() throws { | ||
|
|
||
| //Arrange | ||
| let expectedCarbsInGrams = 15.0 | ||
| let expectedAbsorptionTimeInHours = 3.0 | ||
| let otp = 12345 | ||
| let notification: [String: Any] = [ | ||
| "carbs-entry": expectedCarbsInGrams, | ||
| "absorption-time":expectedAbsorptionTimeInHours, | ||
| "otp": otp, | ||
| "start-time": "invalid-date-string" | ||
| ] | ||
|
|
||
| //Act + Assert | ||
| XCTAssertThrowsError(try RemoteAction.createRemoteAction(notification: notification).get()) | ||
| } | ||
|
|
||
|
|
||
| //MARK: Utils | ||
|
|
||
| func dateFormatter() -> ISO8601DateFormatter { | ||
| let formatter = ISO8601DateFormatter() | ||
| formatter.formatOptions = [.withInternetDateTime, .withFractionalSeconds] | ||
| return formatter | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Async wrapper