Skip to content

Listen for notification when Insulin Delivery Store updates its cache #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aranasaurus wants to merge 3 commits into from
Closed

Listen for notification when Insulin Delivery Store updates its cache #1150

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e19af1
Listen for notification when Insulin Delivery Store updates its cache
aranasaurus Oct 14, 2019
aeec04b
Merge branch 'dev' into update-insulin-graph-HK
aranasaurus Oct 27, 2019
11a1a03
Update log message
aranasaurus Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Loop/Managers/LoopDataManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,19 @@ final class LoopDataManager {

self.insulinEffect = nil

self.notify(forChange: .bolus)
}
},
NotificationCenter.default.addObserver(
Copy link
Collaborator

@ps2 ps2 Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addObserver above this is not specifying a name for notifications from doseStore. Could you add the right name? I believe it is DoseStore.valuesDidChange.

Copy link
Author

@aranasaurus aranasaurus Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I’ll probably be able to do that tomorrow night or this weekend.

forName: .InsulinDeliveryStoreCacheDidChange,
object: doseStore.insulinDeliveryStore,
queue: OperationQueue.main
) { (note) in
self.dataAccessQueue.async {
self.logger.default("Received notification of insulin delivery store cache changing")

self.insulinEffect = nil

self.notify(forChange: .bolus)
}
}
Expand Down