Suggestion: Fully-qualify all emitted code

[dodexahedron]

Looks like a convenient meta-generator. 👍

One suggestion, though, which is relevant to a project I help out with, is to do minor re-write of the source files to fully-qualify all named type symbols. The one that would make me unable to use this in that project is the fact that Attribute isn't fully qualified, since there's an Attribute class in that project and global usings that mean it's accessible everywhere.

This would also have the advantage that the definition of the types in the generator project can use more normal style yet be 100% compatible in any project consuming the generator, if there would otherwise be any name collisions.

I think all you'd need to do to change it is something I use in generators I write, which is just one of the other available overloads of the ToDisplayString() method. To make it nice and concise to use in my generators, I also use the static readonly in the below example, but that's of course optional. I also don't have it emit global:: for them, because a project may have defined an extern alias or something.

    /// <summary>Fully-qualified symbol name format without the "global::" prefix.</summary>
    private static readonly SymbolDisplayFormat _fullyQualifiedSymbolDisplayFormatWithoutGlobal =
        SymbolDisplayFormat.FullyQualifiedFormat.WithGlobalNamespaceStyle (SymbolDisplayGlobalNamespaceStyle.Omitted);

And then, instead of using the empty overload of ToDisplayString(), use this one:

    someNamedTypeSymbol.ToDisplayString (_fullyQualifiedSymbolDisplayFormatWithoutGlobal);

[dodexahedron]

Another idea: This could be optional behavior, settable in your attribute.

[LokiMidgard]

I use Syntax instead of symbol, so I need little bit more…

I tried following code added here

        // We want to copy only the Attributes below the copy Attribute
        var attributesToSkip = syntaxNode.AttributeLists.TakeWhile(list => !list.Attributes.Any(x => x == (SyntaxNode?)context.Attributes.First().ApplicationSyntaxReference!.GetSyntax())).Count() + 1;
        var newAttributiList = syntaxNode.AttributeLists;

        newAttributiList = new SyntaxList<AttributeListSyntax>(syntaxNode.AttributeLists.Select(x => x.WithAttributes(new SeparatedSyntaxList<AttributeSyntax>().AddRange(x.Attributes.Select(a => {
            var sym = context.SemanticModel.GetSymbolInfo(a).Symbol;
            if (sym is not null) {

                var newfull = sym
                    .ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat.WithGlobalNamespaceStyle(SymbolDisplayGlobalNamespaceStyle.Included));
                a = a.WithName(SyntaxFactory.ParseName(newfull));
            }
            return a;
        })))));

        for (int i = 0; i < attributesToSkip; i++) {
            newAttributiList = newAttributiList.RemoveAt(0);
        }

        var syntaxToPrint = syntaxNode.WithAttributeLists(newAttributiList);

But it dose not add a full qualified name…

I'm happy for tips or pull requests ;)

[dodexahedron]

I'd probably be willing to take a look at it once I'm done with some other big tasks for another project and I look back through issues I've opened and whatnot.

[dodexahedron]

Actually one immediate thought:

If, instead of the null check, you do (if sym is INamedTypeSymbol nameItIfYouWantForUseBelow) you might get what you need. 🤔

[dodexahedron]

But yeah - the choice between using Syntax or Symbol is a constant internal battle when writing these I swear. 😅

I usually use Symbol for actual generation purposes and Syntax for analysis/filtering, but there are nearly always points in each analyzer or generator where I end up needing something from the other half of the API.

[dodexahedron]

Also, I'm on my phone at the moment, so it's difficult to be exact, but...

Eyeballing that, I'm not sure a would contain the right thing in the first place. I'll have to look at what I do when I cross the streams, because now I'm curious. 😅

[LokiMidgard]

Your right, The attribute dose not contain the Symbol of the attribute class, but its constructor. It is a IMethodSymbol…

So I need to get the ContainingSymbol

[LokiMidgard]

Ok, I was able to replace attributes by full qualified name, but…

Only Attribute List, it is not done for basetypes or members. :(
Is there no libraray that generates a full qualified string from a symbol?
This look so trublesome🙈

But I have published a new Nuget, since having global qualified attributes, seems already to help you