515 the trusted pluginsjson is written to and loaded from appdatalogexpert in portable mode#532
Merged
Hirogen merged 6 commits intoDevelopmentfrom Mar 3, 2026
Conversation
…om-appdatalogexpert-in-portable-mode' of https://github.com/LogExperts/LogExpert into 515-the-trusted-pluginsjson-is-written-to-and-loaded-from-appdatalogexpert-in-portable-mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to configuration management, especially around portable mode support and migration, as well as modernizes some threading and filtering logic. The most important changes are grouped below.
Configuration Management and Portable Mode Enhancements:
ConfigManagerfor unified portable configuration and session directories (PortableConfigDir,PortableSessionDir,ActiveSessionDir,ActiveConfigDir), and marked the oldPortableModeDiras obsolete for migration purposes.MigrateOldPortableLayout), copying (CopyConfigToPortable), and moving (MoveConfigFromPortable) configuration between standard and portable modes. [1] [2]ActiveConfigDirproperty, ensuring configuration files are saved in the correct location depending on the mode.Threading and Filtering Improvements:
FilterStarter.DoFiltermethod to be asynchronous (returnsTask), runs filter work in parallel tasks, and waits for all tasks to complete before merging results, thus improving performance and reliability. [1] [2] [3]FilterDoneCallbackmethod, simplifying the filter result collection logic.ThreadPool.SetMinThreadsis captured to avoid compiler warnings.Other Codebase Updates:
Persister.SavePersistenceDatamethod to use a more descriptive parameter name (sessionBaseDirectoryinstead ofapplicationStartupPath) and updated its usage accordingly.LogExpert.Core.InterfaceinPersister.csPlatform Targeting:
ConfigManagerclass with the[SupportedOSPlatform("windows")]attribute to clarify platform compatibility.