added json converter for encoding and bookmarks#474
Merged
Hirogen merged 2 commits intoDevelopmentfrom Oct 1, 2025
Conversation
Collaborator
Hirogen
commented
Oct 1, 2025
- fixed bookmarks not saved in PersistenceData
- logexpert project sessions are also in json format
- fixed possible nullreference when filterparams was null / empty and a dirty search was started
- Added JsonConverter for Encodings
fixed bookmarks not saved in PersistenceData and logexpert project sessions are also in json format fixed possible nullreference when filterparams was null / empty and a dirty search was started
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the LogExpert project's persistence system by migrating from XML to JSON format for project files and adding robust JSON serialization support for complex types. The changes improve bookmark persistence and add null safety for filter operations.
Key changes:
- Migrated project file persistence from XML to JSON format
- Added custom JSON converter for Encoding objects to handle serialization properly
- Fixed null reference vulnerability in filter search operations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| LogTabWindow.cs | Updated property name from MemberList to FileNames for project data consistency |
| LogWindow.cs | Added null safety check for filterParams to prevent null reference exceptions |
| Bookmark.cs | Added parameterless constructor with JsonConstructor attribute for JSON deserialization |
| ProjectPersister.cs | Complete rewrite from XML to JSON persistence with proper error handling |
| ProjectData.cs | Renamed MemberList to FileNames and added XML documentation |
| Persister.cs | Consolidated JSON settings and added EncodingJsonConverter for centralized configuration |
| PersistenceData.cs | Added JsonConverter attribute for Encoding property |
| EncodingJsonConverter.cs | New custom JSON converter for proper Encoding serialization/deserialization |
This was referenced Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.