Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to version 1.20.0, adds GitVersion integration, and modernizes some UI initialization and metadata logic.
- Included
GitVersion.ymlin solution items. - Bumped assembly and file versions to 1.20.0 and replaced placeholder metadata.
- Refactored attribute retrieval in
AboutBoxand adjusted link/DataGrid initializations.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/LogExpert.sln | Added GitVersion.yml to solution items |
| src/LogExpert.UI/Dialogs/AboutBox.cs | Simplified string checks, added discard assignments, UI tweaks |
| src/LogExpert.UI/Controls/LogWindow/LogWindow.cs | Removed stray whitespace |
| src/Directory.Build.props | Updated version numbers and filled in AssemblyTitle/Description |
| lib/3rdparty.txt | Updated DockPanel Suite URL to GitHub |
Files not reviewed (1)
- src/LogExpert.UI/Dialogs/AboutBox.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)
src/LogExpert.UI/Dialogs/AboutBox.cs:83
- The special handling for revisions >= 9000 that appended " Testrelease" has been removed. If that suffix is still required for test builds, reintroduce the conditional logic.
return assembly.Version != null
|
|
||
| LoadResources(); | ||
|
|
||
| usedComponentsDataGrid.AutoSizeColumnsMode = DataGridViewAutoSizeColumnsMode.Fill; |
There was a problem hiding this comment.
[nitpick] Consider setting the DataGridView's AutoSizeColumnsMode in the designer rather than at runtime to keep UI configuration centralized.
| <AssemblyTitle>FIX ME - AssemblyTitle!</AssemblyTitle> | ||
| <Description>FIX ME - Description!</Description> | ||
| <AssemblyTitle>LogExpert</AssemblyTitle> | ||
| <Description> |
There was a problem hiding this comment.
[nitpick] The project description XML is very verbose. Consider moving detailed feature lists to external documentation and keeping the element concise for easier maintenance.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.20.0