Skip to content

402 - Pre PR#434

Merged
Hirogen merged 4 commits intoLogExperts:Developmentfrom
RandallFlagg:402_logfilereader
Jul 7, 2025
Merged

402 - Pre PR#434
Hirogen merged 4 commits intoLogExperts:Developmentfrom
RandallFlagg:402_logfilereader

Conversation

@RandallFlagg
Copy link
Copy Markdown
Contributor

This is a pre PR for issue #402:
Changed the LogFileReader constructor in order to better encapsulate fields.
Fixed some warnings.
Changed type LogLine from class to record.

Copy link
Copy Markdown
Collaborator

@Hirogen Hirogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the Winforms File to one file, so we don't have the resx problems

@RandallFlagg
Copy link
Copy Markdown
Contributor Author

Please merge the Winforms File to one file, so we don't have the resx problems

I will do this in a separate PR

RandallFlagg pushed a commit to RandallFlagg/LogExpert that referenced this pull request Jun 28, 2025
@RandallFlagg RandallFlagg requested a review from Hirogen June 29, 2025 00:09
@Hirogen
Copy link
Copy Markdown
Collaborator

Hirogen commented Jun 30, 2025

Please merge the Winforms File to one file, so we don't have the resx problems

I will do this in a separate PR

it's already in the dev branch, your change would revert that again

Copy link
Copy Markdown
Collaborator

@Hirogen Hirogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Hirogen and others added 2 commits July 6, 2025 12:59
…fields.

Fixed some warnings.
Changed type LogLine from class to record.
@Hirogen Hirogen merged commit c0df0ba into LogExperts:Development Jul 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants