Skip to content

Decouple UI businesslogic#372

Merged
Hirogen merged 4 commits intoDevelopmentfrom
decouple_ui_businesslogic
Apr 10, 2025
Merged

Decouple UI businesslogic#372
Hirogen merged 4 commits intoDevelopmentfrom
decouple_ui_businesslogic

Conversation

@Hirogen
Copy link
Copy Markdown
Collaborator

@Hirogen Hirogen commented Mar 27, 2025

Reshuffling a lot of files and updating references

@Hirogen Hirogen requested a review from Copilot March 27, 2025 16:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR decouples UI business logic by reorganizing namespaces and file structures across the solution and updating references accordingly. Key changes include:

  • Updating using directives to the new LogExpert.Core and related namespaces across tests and production code.
  • Adjusting method calls and parameters in the ColumnizerPicker tests to use the updated PluginRegistry instance.
  • Refactoring the CsvColumnizer to use new using declaration syntax.

Reviewed Changes

Copilot reviewed 178 out of 179 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/LogExpert.Tests/ReaderTest.cs Updated using directives for LogExpert core namespaces
src/LogExpert.Tests/LogStreamReaderTest.cs Updated using directives for LogExpert core namespaces
src/LogExpert.Tests/LocalFileSystemTest.cs Adjusted using directives to align with refactored namespaces
src/LogExpert.Tests/JsonCompactColumnizerTest.cs Updated entity imports to new LogExpert.Core.Entities namespace
src/LogExpert.Tests/JsonColumnizerTest.cs Updated entity imports to new LogExpert.Core.Entities namespace
src/LogExpert.Tests/JSONSaveTest.cs Added using directive for LogExpert.Core.Config
src/LogExpert.Tests/Extensions/EnumerableTests.cs Changed using directive from LogExpert.Extensions to LogExpert.Core.Extensions
src/LogExpert.Tests/DateFormatParserTest.cs Updated using directives to new LogExpert.Core namespaces
src/LogExpert.Tests/ColumnizerPickerTest.cs Updated PluginRegistry usage and method parameter list
src/LogExpert.Tests/CSVColumnizerTest.cs Updated entity imports to new LogExpert.Core.Entities namespace
src/LogExpert.Tests/BufferShiftTest.cs Added using directives for LogExpert.Core classes and PluginRegistry usage
src/Log4jXmlColumnizer/Log4jXmlColumnizerConfigDlg.cs Updated using directive to reference Log4jXmlColumnizer
src/Log4jXmlColumnizer/Log4jXmlColumnizer.cs Changed namespace from LogExpert to Log4jXmlColumnizer
src/CsvColumnizer/CsvColumnizer.cs Refactored CsvReader usage to new using declaration syntax
src/ColumnizerLib/IXmlLogConfiguration.cs Removed unnecessary using directives
src/ColumnizerLib/IFileSystemPlugin.cs Removed unnecessary using directives
src/ColumnizerLib/Extensions/LogLineExtensions.cs Changed namespace from LogExpert to LogExpert.Extensions
src/ColumnizerLib.UnitTests/Extensions/LogLineExtensionsTests.cs Updated using directive to match the production namespace
src/AutoColumnizer/AutoColumnizer.cs Changed namespace from LogExpert to AutoColumnizer and added using LogExpert
Files not reviewed (1)
  • src/Directory.Packages.props: Language not supported
Comments suppressed due to low confidence (1)

src/LogExpert.Tests/Extensions/EnumerableTests.cs:1

  • Verify that the namespace update for extension methods in test files (LogExpert.Core.Extensions) is consistent with the production code, which remains in LogExpert.Extensions. If not, adjust the namespace in either the tests or the production code to maintain consistency.
using LogExpert.Core.Extensions;

@Hirogen Hirogen merged commit fe25a88 into Development Apr 10, 2025
1 check passed
@Hirogen Hirogen linked an issue May 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seperate the LogExpert logic into a new project

2 participants