Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR decouples UI business logic by reorganizing namespaces and file structures across the solution and updating references accordingly. Key changes include:
- Updating using directives to the new LogExpert.Core and related namespaces across tests and production code.
- Adjusting method calls and parameters in the ColumnizerPicker tests to use the updated PluginRegistry instance.
- Refactoring the CsvColumnizer to use new using declaration syntax.
Reviewed Changes
Copilot reviewed 178 out of 179 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/LogExpert.Tests/ReaderTest.cs | Updated using directives for LogExpert core namespaces |
| src/LogExpert.Tests/LogStreamReaderTest.cs | Updated using directives for LogExpert core namespaces |
| src/LogExpert.Tests/LocalFileSystemTest.cs | Adjusted using directives to align with refactored namespaces |
| src/LogExpert.Tests/JsonCompactColumnizerTest.cs | Updated entity imports to new LogExpert.Core.Entities namespace |
| src/LogExpert.Tests/JsonColumnizerTest.cs | Updated entity imports to new LogExpert.Core.Entities namespace |
| src/LogExpert.Tests/JSONSaveTest.cs | Added using directive for LogExpert.Core.Config |
| src/LogExpert.Tests/Extensions/EnumerableTests.cs | Changed using directive from LogExpert.Extensions to LogExpert.Core.Extensions |
| src/LogExpert.Tests/DateFormatParserTest.cs | Updated using directives to new LogExpert.Core namespaces |
| src/LogExpert.Tests/ColumnizerPickerTest.cs | Updated PluginRegistry usage and method parameter list |
| src/LogExpert.Tests/CSVColumnizerTest.cs | Updated entity imports to new LogExpert.Core.Entities namespace |
| src/LogExpert.Tests/BufferShiftTest.cs | Added using directives for LogExpert.Core classes and PluginRegistry usage |
| src/Log4jXmlColumnizer/Log4jXmlColumnizerConfigDlg.cs | Updated using directive to reference Log4jXmlColumnizer |
| src/Log4jXmlColumnizer/Log4jXmlColumnizer.cs | Changed namespace from LogExpert to Log4jXmlColumnizer |
| src/CsvColumnizer/CsvColumnizer.cs | Refactored CsvReader usage to new using declaration syntax |
| src/ColumnizerLib/IXmlLogConfiguration.cs | Removed unnecessary using directives |
| src/ColumnizerLib/IFileSystemPlugin.cs | Removed unnecessary using directives |
| src/ColumnizerLib/Extensions/LogLineExtensions.cs | Changed namespace from LogExpert to LogExpert.Extensions |
| src/ColumnizerLib.UnitTests/Extensions/LogLineExtensionsTests.cs | Updated using directive to match the production namespace |
| src/AutoColumnizer/AutoColumnizer.cs | Changed namespace from LogExpert to AutoColumnizer and added using LogExpert |
Files not reviewed (1)
- src/Directory.Packages.props: Language not supported
Comments suppressed due to low confidence (1)
src/LogExpert.Tests/Extensions/EnumerableTests.cs:1
- Verify that the namespace update for extension methods in test files (LogExpert.Core.Extensions) is consistent with the production code, which remains in LogExpert.Extensions. If not, adjust the namespace in either the tests or the production code to maintain consistency.
using LogExpert.Core.Extensions;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reshuffling a lot of files and updating references