Making sure the appBounds in the Settings are within the current virt…#287
Merged
Hirogen merged 1 commit intoLogExperts:Developmentfrom Nov 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix looks at the stored appBounds information and make sure that the values are within the current virtual desktop bounds. It can happen that when you work on different virtual desktops the stored information is out of bounds making it impossible to locate or restore the view position. This is now checked and if the values are out of bounds the default windows bound setting is used.
The check is done in the ConfigManager just after the settings has been loaded. If the values in the appBounds are out of bounds for the current virtuel desktop the appBounds are set to 0 values. The views already checks for null and right value = 0 and skip setting the Bounds if so. This makes windows use the default values of the views and therefore showing on the primary screen.