Allow resize and add autosize to the filter box (close #177)#193
Merged
Hirogen merged 3 commits intoLogExperts:Developmentfrom Nov 15, 2021
Merged
Conversation
Hirogen
reviewed
Nov 11, 2021
Collaborator
Hirogen
left a comment
There was a problem hiding this comment.
In filterSplitContainer_MouseMove please cast the object only once
ex: SplitContainer container = (SplitContainer)sender;
this will make the source code clearer to read and also it is only converted once, not multiple times
other than that looks fine for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zarunbal please review the code. You'll notice some misplaced code in form designer code, unfortunately VS2019 seems to be not too friendly with multiple partial form files. IMHO all these logic should be moved to specialized classes instead of partial form files.