feat(aws/recs): populate ComputeDetails.VCPU/MemoryGB via DescribeInstanceTypes (closes #218) by cristim · Pull Request #816 · LeanerCloud/CUDly

cristim · 2026-05-28T18:33:12Z

Summary

Adds a per-Client instance-type SKU catalogue fetched once per lifetime via ec2:DescribeInstanceTypes (paginated), cached with sync.Once
Populates ComputeDetails.VCPU and MemoryGB in parseEC2Details from the catalogue; falls back to 0 on cache miss or fetch failure (graceful degradation, mirrors Azure PR feat(azure/recs): populate ComputeDetails.VCPU/MemoryGB via cached SKU lookup (closes #217) #810)
Threads context.Context through parseRecommendations -> parseRecommendationDetail -> parseServiceSpecificDetails -> service parsers to carry cancellation to the catalogue walk

IAM

ec2:DescribeInstanceTypes is covered by the existing ec2:Describe* wildcard in the deploy SAs; no new policy statement required.

Test plan

coderabbitai · 2026-05-28T18:33:19Z

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 78 minutes and 51 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 346cf6fa-490f-4597-8c30-325be72fd287

📥 Commits

Reviewing files that changed from the base of the PR and between 55739c2 and d756be7.

📒 Files selected for processing (7)

providers/aws/recommendations/client.go
providers/aws/recommendations/parser_ri.go
providers/aws/recommendations/parser_ri_test.go
providers/aws/recommendations/parser_services.go
providers/aws/recommendations/parser_services_test.go
providers/aws/recommendations/sku.go
providers/aws/recommendations/sku_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/218-wave6

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cristim · 2026-05-28T18:33:21Z

@coderabbitai review

coderabbitai · 2026-05-28T18:33:26Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-05-28T19:55:22Z

Coordination note: PR #842 (closes #99) implements the same DescribeInstanceTypes VCPU/MemoryGB population path independently. The two PRs are effectively duplicates. Whichever lands first should be merged; the other should be closed (or rebased to a tightening-only delta). Both currently open; flagging so the merger doesn't accidentally land both.

cristim · 2026-05-30T10:22:29Z

@coderabbitai full review

coderabbitai · 2026-05-30T10:22:34Z

✅ Actions performed

Full review triggered.

cristim · 2026-06-01T22:28:52Z

@coderabbitai review

coderabbitai · 2026-06-01T22:28:57Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

#219) Add a new "Capacity" column to the recommendations table immediately after "Resource Type". The column renders "N vCPU / M GB" when the backend populates ComputeDetails.VCPU and ComputeDetails.MemoryGB (populated by PRs #810/#816/#833 for Azure/AWS/GCP). Recs without those fields show a dash, matching the feedback_nullable_not_zero rule. Changes: - types.ts: add vcpu/memory_gb optional fields to LocalRecommendation - state.ts: add 'capacity' to RecommendationsColumnId - recommendations.ts: add COLUMN_DEFS entry, formatCapacity() helper, and cases in categoricalCellValue/numericCellValue/displayPrecision/ renderColumnCell; all innerHTML values go through escapeHtml() - tests: +11 tests (formatCapacity unit, capacity filter, column count and position assertions); update 5 hardcoded td-index/column-list assertions shifted by the new column

cristim · 2026-06-04T14:04:27Z

@coderabbitai review

coderabbitai · 2026-06-04T14:04:34Z

Rate Limit Exceeded

@cristim have exceeded the limit for the number of chat messages per hour. Please wait 39 minutes and 1 seconds before sending another message.

…tanceTypes (closes #218) Add a per-Client instance-type SKU catalogue fetched once per scheduler tick via ec2:DescribeInstanceTypes (paginated, sync.Once cached). parseEC2Details now enriches ComputeDetails.VCPU and MemoryGB from the catalogue; catalogue miss or fetch failure leaves both fields at 0 (graceful degradation, mirrors Azure PR #810). Context is threaded through parseRecommendations/parseRecommendationDetail/ parseServiceSpecificDetails so the paginator walk honours cancellation (ctx_cancel_terminal pattern). IAM: ec2:DescribeInstanceTypes is covered by the existing ec2:Describe* wildcard; no new policy statement required. Tests: 293 pass (+13 new) including one-call-per-lifetime invariant, page-error graceful degradation, and ctx-cancel short-circuit.

Fix two pre-commit failures: - sku_test.go: gofmt reorders imports into canonical alphabetical order - parser_services.go: extract resolveEC2Tenancy, resolveEC2Scope, and enrichFromCatalogue helpers from parseEC2Details; complexity drops from 14 to 7, clearing the gocyclo hook

cristim · 2026-06-05T11:19:22Z

Rebased on feat/multicloud-web-frontend. Resolved conflict in providers/aws/recommendations/parser_services.go and parser_services_test.go (parseMemoryDBDetails signature: kept fail-loudly semantics from base, restored context.Context param for serviceParserFunc type consistency).

cristim · 2026-06-05T11:19:34Z

@coderabbitai review

coderabbitai · 2026-06-05T11:19:40Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristim · 2026-06-05T17:15:12Z

Verification note: PR #842 (closes #99) implements the same EC2 DescribeInstanceTypes VCPU/MemoryGB enrichment as this PR (closes #218), on the same base. Duplicate solutions that will conflict - recommend merging one and closing the other's issue as a duplicate. Leaving the pick for a human.

…ctx; drop em-dashes The ComputeDetails VCPU/MemoryGB implementation landed via the merged duplicate PR #816 (closes #218). This commit grafts the two test-coverage gaps that #816 missed, plus a comment cleanup: - TestExtractInstanceTypeSKUEntry: add sub-case "MemoryInfo present but SizeInMiB nil" -- expects VCPU populated, MemGB 0.0. - TestFetchInstanceTypeCatalogue_ContextCanceled: assert that pager.callCount remains 0 after a pre-canceled ctx returns nil (the stub already tracks the count via atomic; this makes the no-NextPage contract explicit). - Replace em-dashes (U+2014) with "--" in sku.go warn messages and in the client.go instanceTypeLookup comment. parser_services.go em-dashes left for a follow-up (out of scope here). Closes #99

cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/this-quarter Within the quarter impact/few Limited audience effort/m Days type/feat New capability labels May 28, 2026

This was referenced May 28, 2026

feat(frontend/recs): surface VCPU + MemoryGB in table (closes #219) #840

Merged

test(aws/recs): cover SizeInMiB-nil + assert no NextPage on canceled ctx; drop em-dashes #842

Merged

cristim added 2 commits June 5, 2026 13:17

cristim force-pushed the fix/218-wave6 branch from d5dbfac to d756be7 Compare June 5, 2026 11:19

cristim merged commit 209db78 into feat/multicloud-web-frontend Jun 6, 2026
4 checks passed

cristim deleted the fix/218-wave6 branch July 27, 2026 11:09

Uh oh!

Conversation

cristim commented May 28, 2026

Summary

IAM

Test plan

Uh oh!

coderabbitai Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

cristim commented May 28, 2026

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

cristim commented May 28, 2026

Uh oh!

cristim commented May 30, 2026

Uh oh!

coderabbitai Bot commented May 30, 2026

Uh oh!

cristim commented Jun 1, 2026

Uh oh!

coderabbitai Bot commented Jun 1, 2026

Uh oh!

cristim commented Jun 4, 2026

Uh oh!

coderabbitai Bot commented Jun 4, 2026

Rate Limit Exceeded

Uh oh!

cristim commented Jun 5, 2026

Uh oh!

cristim commented Jun 5, 2026

Uh oh!

coderabbitai Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristim commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented May 28, 2026 •

edited

Loading

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading